Skip to content

Fix panic when cloning with wrong ssh format. #32076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 24, 2024
Merged

Fix panic when cloning with wrong ssh format. #32076

merged 8 commits into from
Sep 24, 2024

Conversation

@lunny
Copy link
Member

@lunny lunny commented Sep 19, 2024

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 19, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin labels Sep 19, 2024
@yp05327 yp05327 added this to the 1.23.0 milestone Sep 19, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 20, 2024
wxiaoguang
wxiaoguang reviewed Sep 20, 2024
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 24, 2024
@lunny lunny enabled auto-merge (squash) September 24, 2024 00:45
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 24, 2024
@lunny lunny merged commit 3f2d8f8 into go-gitea:main Sep 24, 2024
26 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Sep 24, 2024
@lunny @GiteaBot
Fix panic when cloning with wrong ssh format. (go-gitea#32076)
dc7293c
@GiteaBot GiteaBot mentioned this pull request Sep 24, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Sep 24, 2024
lunny added a commit that referenced this pull request Sep 24, 2024
@GiteaBot @lunny
Fix panic when cloning with wrong ssh format. (#32076) (#32118)
a3c660f 
Backport #32076 by @lunny

Co-authored-by: Lunny Xiao <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 24, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
b792231 
* giteaofficial/main:
  Allow set branch protection in an empty repository (go-gitea#32095)
  Fix panic when cloning with wrong ssh format. (go-gitea#32076)
  Fix bug in getting merged pull request by commit (go-gitea#32079)
  [skip ci] Updated translations via Crowdin
  use rebuilt mssql-2017 image (go-gitea#32109)
  Fix Bug in Issue/pulls list (go-gitea#32081)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@lafriks lafriks lafriks approved these changes

@yp05327 yp05327 yp05327 approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code type/bug

Projects

None yet

Milestone

1.23.0

Development

Successfully merging this pull request may close these issues.

5 participants

@lunny @lafriks @wxiaoguang @yp05327 @GiteaBot