Correctly query the primary button in a form #32438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
added
type/bug
skip-changelog
wxiaoguang
force-pushed
the
fix-form-button
branch
from
b565a1e to
df8210f
Compare
silverwind
reviewed
Nov 6, 2024
silverwind
approved these changes
Nov 6, 2024
GiteaBot
added
lgtm/need 1
silverwind
reviewed
Nov 6, 2024
lunny
approved these changes
Nov 6, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 7, 2024
* giteaofficial/main: Add new index for action to resolve the performance problem (go-gitea#32333) Include file extension checks in attachment API (go-gitea#32151) Updated tokenizer to better matching when search for code snippets (go-gitea#32261) Correctly query the primary button in a form (go-gitea#32438) # Conflicts: # web_src/js/utils/dom.ts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "primary button" is used at many places, but sometimes they might conflict (due to button switch, hidden panel, dropdown menu, etc).
Sometimes we could add a special CSS class for the buttons, but sometimes not (see the comment of QuickSubmit)
This PR introduces
querySingleVisibleElemto help to get the correct primary button (the only visible one), and prevent from querying the wrong buttons.Fix #32437