- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 6.2k
Fix a missed return in OAuth2 #35655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          
      
        
          +1
        
        
          −0
        
        
          
        
      
    
  
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    silverwind
  
              
              approved these changes
              
                  
                    Oct 14, 2025 
                  
              
              
            
            
              
                    delvh
  
              
              approved these changes
              
                  
                    Oct 14, 2025 
                  
              
              
            
            
    
  GiteaBot 
      pushed a commit
        to GiteaBot/gitea
      that referenced
      this pull request
    
      Oct 15, 2025 
    
    
  
    
  GiteaBot 
      pushed a commit
        to GiteaBot/gitea
      that referenced
      this pull request
    
      Oct 15, 2025 
    
    
  
    
  silverwind 
      pushed a commit
      that referenced
      this pull request
    
      Oct 15, 2025 
    
    
      
  
    
      
    
  
Backport #35655 by @lunny Co-authored-by: Lunny Xiao <[email protected]>
    
  lunny 
      added a commit
      that referenced
      this pull request
    
      Oct 15, 2025 
    
    
      
  
    
      
    
  
Backport #35655 by @lunny Co-authored-by: Lunny Xiao <[email protected]>
    
  zjjhot 
      added a commit
        to zjjhot/gitea
      that referenced
      this pull request
    
      Oct 16, 2025 
    
    
      
  
    
      
    
  
* giteaofficial/main: Bump happy-dom from 20.0.0 to 20.0.2 (go-gitea#35677) Fix missing Close when error occurs and abused connection pool (go-gitea#35658) Upgrade to go 1.25.3 (go-gitea#35656) Always create Actions logs stepsContainer (go-gitea#35654) Fix a bug missed return (go-gitea#35655)
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    backport/done
  All backports for this PR have been created 
  
    backport/v1.24
  This PR should be backported to Gitea 1.24 
  
    backport/v1.25
  
    lgtm/done
  This PR has enough approvals to get merged. There are no important open reservations anymore. 
  
    modifies/go
  Pull requests that update Go code 
  
    topic/security
  Something leaks user information or is otherwise vulnerable. Should be fixed! 
  
    type/bug
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
No description provided.