Skip to content

Remove unnecessary code and fix comments #35761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 28, 2025
Merged

Remove unnecessary code and fix comments #35761

merged 6 commits into from
Oct 28, 2025
+30 −48

Conversation

@lunny
Copy link
Member

@lunny lunny commented Oct 28, 2025 •
edited by wxiaoguang
Loading

Follow #35459, #32562

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Oct 28, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 28, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Oct 28, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 28, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 28, 2025
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Oct 28, 2025
@wxiaoguang wxiaoguang changed the title Remove unnecessary function parameter Remove unnecessary code Oct 28, 2025
@wxiaoguang wxiaoguang mentioned this pull request Oct 28, 2025
Merged
@wxiaoguang wxiaoguang requested a review from Zettat123 October 28, 2025 11:52
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Oct 28, 2025
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Oct 28, 2025
@wxiaoguang wxiaoguang mentioned this pull request Oct 28, 2025
Closed
10 tasks
@wxiaoguang wxiaoguang changed the title Remove unnecessary code Remove unnecessary code and fix comments Oct 28, 2025
@wxiaoguang wxiaoguang mentioned this pull request Oct 28, 2025
Closed
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 28, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 28, 2025
@lunny lunny enabled auto-merge (squash) October 28, 2025 17:35
@lunny lunny merged commit 95b18eb into go-gitea:main Oct 28, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Oct 28, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 28, 2025
@lunny lunny deleted the lunny/remove_unnecessary_parameter branch October 28, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

+1 more reviewer

@Zettat123 Zettat123 Zettat123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lunny @wxiaoguang @Zettat123 @GiteaBot