Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #553 +/- ##
=======================================
Coverage 90.91% 90.91%
=======================================
Files 47 47
Lines 4547 4547
Branches 601 601
=======================================
Hits 4134 4134
Misses 273 273
Partials 140 140 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
goatshriek
requested changes
Feb 18, 2026
Owner
goatshriek
left a comment
There was a problem hiding this comment.
Thanks very much for putting this together! Just one update to the header and a few lines that need to be broken up so that they aren't too long (see the static analysis run), and then this should be good to go!
Comment on lines
+25
to
+26
| #ifndef __STUMPLESS_PRIVATE_CONFIG_LOCALE_EN_US_H | ||
| # define __STUMPLESS_PRIVATE_CONFIG_LOCALE_EN_US_H |
Owner
There was a problem hiding this comment.
Update this header guard to use __STUMPLESS_PRIVATE_CONFIG_LOCALE_GA_IE_H
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds Irish (ga_IE) localization support to Stumpless by introducing translated message strings and the corresponding locale configuration. The goal is to expand language coverage while maintaining consistency with existing localization patterns and conventions. This change resolves Issue #117 reported on GitHub.
Guidelines for Contributing.