-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update Playing Videos page for Godot 4.5 #10972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What specifically in this PR only applies to 4.5? |
I've removed some limitations. I've taken the opportunity to rework some of the text I did previously, and reference Shutter Encoder. |
|
Got it. This needs to be rebased since I just merged #10721. Also is there a reason this is marked as a draft? |
|
Oh, sorry, I had forgot about that PR. There's another limitation to remove. I'll do it in this PR. It's marked as a draft because one of the new features wasn't yet merged. Now that it is I'll update this PR. The reason I've reworked some of my previous additions to this page is that I feel a bit insecure writing documentation. When I read some parts of it, it feels too verbose or more intricate than necessary. Your judgement on this would help me. Thanks. |
0d450ef to
3abcd3b
Compare
|
Description updated. |
3abcd3b to
aa7351f
Compare
|
After testing Shutter Encoder myself I've decided against including it in the docs because it uses the worst possible encoding parameters and offers no way to change them. |
skyace65
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only one minor change needs to be made.
aa7351f to
bca64c8
Compare
|
I've moved the doc comment below the warning that it refers to so that it's more clear where it belongs. I've added the commit refs to the comment and a minor rewording of the warning. |
|
Thanks! |
Removed another limitation: change playback speed.
Added Shutter Encoder as a FFmpeg GUI. Related to #10942.I've decided to remove the date from the FFmpeg warning since they have already released a point version but without the fix. And I don't know how many more they will release yet. I hoped that the next major version was closer to being released.
Changed the GOP description a bit to hopefully better fit the rest of the documentation.