Skip to content

Conversation

@berarma
Copy link
Contributor

@berarma berarma commented May 28, 2025

Removed another limitation: change playback speed.

Added Shutter Encoder as a FFmpeg GUI. Related to #10942.

I've decided to remove the date from the FFmpeg warning since they have already released a point version but without the fix. And I don't know how many more they will release yet. I hoped that the next major version was closer to being released.

Changed the GOP description a bit to hopefully better fit the rest of the documentation.

@skyace65
Copy link
Contributor

What specifically in this PR only applies to 4.5?

@berarma
Copy link
Contributor Author

berarma commented May 29, 2025

What specifically in this PR only applies to 4.5?

I've removed some limitations. I've taken the opportunity to rework some of the text I did previously, and reference Shutter Encoder.

@skyace65
Copy link
Contributor

skyace65 commented Jun 8, 2025

Got it. This needs to be rebased since I just merged #10721. Also is there a reason this is marked as a draft?

@berarma
Copy link
Contributor Author

berarma commented Jun 8, 2025

Oh, sorry, I had forgot about that PR. There's another limitation to remove. I'll do it in this PR.

It's marked as a draft because one of the new features wasn't yet merged. Now that it is I'll update this PR.

The reason I've reworked some of my previous additions to this page is that I feel a bit insecure writing documentation. When I read some parts of it, it feels too verbose or more intricate than necessary. Your judgement on this would help me. Thanks.

@berarma berarma force-pushed the playing_videos_4.5 branch 2 times, most recently from 0d450ef to 3abcd3b Compare June 9, 2025 11:39
@berarma berarma marked this pull request as ready for review June 9, 2025 11:47
@berarma
Copy link
Contributor Author

berarma commented Jun 9, 2025

Description updated.

@AThousandShips AThousandShips added area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:animation labels Jun 9, 2025
@AThousandShips AThousandShips added this to the 4.5 milestone Jun 9, 2025
@berarma berarma force-pushed the playing_videos_4.5 branch from 3abcd3b to aa7351f Compare June 17, 2025 14:11
@berarma
Copy link
Contributor Author

berarma commented Jun 17, 2025

After testing Shutter Encoder myself I've decided against including it in the docs because it uses the worst possible encoding parameters and offers no way to change them.

Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only one minor change needs to be made.

@berarma berarma force-pushed the playing_videos_4.5 branch from aa7351f to bca64c8 Compare June 27, 2025 10:50
@berarma
Copy link
Contributor Author

berarma commented Jun 27, 2025

I've moved the doc comment below the warning that it refers to so that it's more clear where it belongs. I've added the commit refs to the comment and a minor rewording of the warning.

@skyace65 skyace65 merged commit 6e72ab3 into godotengine:master Jun 27, 2025
1 check passed
@skyace65
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:animation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants