Skip to content

Conversation

@dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Nov 1, 2025

Up until now, we haven't had any way to register compatibility methods for builtin methods, which has meant that we couldn't change their signature.

This has blocked moving forward on a number of issues, including #79140

This PR adds such a system!

In order to test it, I've also implemented the main change from #79140 in the 2nd commit.

cc @aaronfranke

Supersedes #79140

@dsnopek dsnopek added this to the 4.6 milestone Nov 1, 2025
@dsnopek dsnopek requested a review from a team as a code owner November 1, 2025 19:07
@dsnopek dsnopek requested a review from a team as a code owner November 1, 2025 19:07
@dsnopek dsnopek requested a review from aaronfranke November 1, 2025 19:07
@dsnopek dsnopek force-pushed the variant-call-compat-methods branch from 52490b0 to 1b76718 Compare November 1, 2025 19:54
@dsnopek dsnopek requested review from a team as code owners November 1, 2025 19:54
@dsnopek dsnopek force-pushed the variant-call-compat-methods branch from 1b76718 to d666f67 Compare November 1, 2025 20:31
@dsnopek dsnopek force-pushed the variant-call-compat-methods branch from d666f67 to 75731f8 Compare November 2, 2025 21:40
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the details here are beyond my expertise, but suffice to say, so long as it works, I'm happy with it!

Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and cases look good to me

@dsnopek dsnopek force-pushed the variant-call-compat-methods branch from 75731f8 to 1e12993 Compare November 3, 2025 11:12
Copy link
Member

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree this addition is needed. Code and approach look good to me.
Only caveat I have is I haven't tested it, but since David tested this that's good enough for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants