fix: allow admin users to skip old password input#754
Open
adityashekhawat1999 wants to merge 2 commits intogoharbor:mainfrom
Open
fix: allow admin users to skip old password input#754adityashekhawat1999 wants to merge 2 commits intogoharbor:mainfrom
adityashekhawat1999 wants to merge 2 commits intogoharbor:mainfrom
Conversation
Signed-off-by: Aditya Pratap Singh Shekhawat <adityashekhawat@Adityas-MacBook-Air.local> :wq :Wq :wq
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #754 +/- ##
=========================================
- Coverage 10.99% 7.81% -3.18%
=========================================
Files 173 270 +97
Lines 8671 13171 +4500
=========================================
+ Hits 953 1029 +76
- Misses 7612 12029 +4417
- Partials 106 113 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@NucleoFusion The cli would still send the old password field(empty for admin), i wanted to ask is that acceptable for the API or should the field be omitted entirely |
Contributor
|
This should be fine, will have a better look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates the
user passwordcommand to allow admin users to skip entering the old password.Right now, the CLI always requires the old password but according to the API behaviour it’s optional for admins.
Type of Change
Please select the relevant type.
Changes
--adminflag to the password command--adminis used