Skip to content

fix: allow admin users to skip old password input #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adityashekhawat1999 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: allow admin users to skip old password input #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8f2055
fix: allow admin users to skip old password input
Mar 18, 2026
4f12457
docs: update password command docs
Mar 18, 2026
daea2a0
docs: regenerate docs for password command
Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmd/harbor/root/password.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,14 @@ import (

func PasswordCommand() *cobra.Command {
var opts change.PasswordChangeView
var isAdmin bool

cmd := &cobra.Command{
Use: "password",
Short: "Change your password",
Args: cobra.MinimumNArgs(0),
RunE: func(cmd *cobra.Command, args []string) error {
change.ChangePasswordView(&opts)
change.ChangePasswordView(&opts, isAdmin)

err := UpdatePassword(&opts)
if err != nil {
Expand All @@ -41,6 +42,8 @@ func PasswordCommand() *cobra.Command {
},
}

cmd.Flags().BoolVar(&isAdmin, "admin", false, "Admin password change")

return cmd
}

Expand Down
3 changes: 2 additions & 1 deletion doc/cli-docs/harbor-password.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ harbor password [flags]
### Options

```sh
-h, --help help for password
--admin Admin password change
-h, --help help for password
```

### Options inherited from parent commands
Expand Down
4 changes: 4 additions & 0 deletions doc/man-docs/man1/harbor-password.1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ Change your password


.SH OPTIONS
\fB--admin\fP[=false]
Admin password change

.PP
\fB-h\fP, \fB--help\fP[=false]
help for password

Expand Down
4 changes: 2 additions & 2 deletions pkg/views/password/change/view.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ type PasswordChangeView struct {
ConfirmPassword string
}

func ChangePasswordView(view *PasswordChangeView) {
func ChangePasswordView(view *PasswordChangeView, isAdmin bool) {
theme := huh.ThemeCharm()

err := huh.NewForm(
Expand All @@ -38,7 +38,7 @@ func ChangePasswordView(view *PasswordChangeView) {
EchoMode(huh.EchoModePassword).
Value(&view.OldPassword).
Validate(func(str string) error {
if strings.TrimSpace(str) == "" {
if !isAdmin && strings.TrimSpace(str) == "" {
return errors.New("old password cannot be empty")
}
return nil
Expand Down
Loading