Skip to content

cmd/go: invalidate coverage report cache when coverpkg sources change #74773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cmd/go: invalidate coverage report cache when coverpkg sources change #74773

wants to merge 1 commit into from
+161 −1

Conversation

ryancurrah
Copy link
Contributor

@ryancurrah ryancurrah commented Jul 27, 2025 •
edited
Loading

When using -coverpkg, test caching could return stale coverage data
if covered packages were modified but the test package itself was
unchanged. This occurred because the test cache didn't track changes
to packages specified by -coverpkg.

This change adds additional cache invalidation for coverage reports
by including covered package source file hashes in the coverage
profile cache key:

  • Add hashCoveredPackages function to hash source files of covered packages
  • Modify coverProfileAndInputKey to include covered packages hash
  • Add test case to verify coverage report cache invalidation works correctly

Coverage reports are still invalidated when test packages change (as before),
and now also invalidated when any coverpkg-specified package changes,
improving cache accuracy while maintaining performance.

Fixes issue where coverage reports contained duplicate entries with
different line ranges after source modifications in covered packages.

Fixes #74873

@ryancurrah ryancurrah mentioned this pull request Jul 27, 2025
Closed
@gopherbot
Copy link
Contributor

This PR (HEAD: bb12492) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690775.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/690775.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jorropo:

Patch Set 1: Commit-Queue+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/690775.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-07-29T11:16:25Z","revision":"7c78557e0f55c0fbd57694af257866cdad171575"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/690775.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jorropo:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/690775.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/690775.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/690775.
After addressing review feedback, remember to publish your drafts!

@austinderek austinderek mentioned this pull request Aug 4, 2025
Open
@ryancurrah ryancurrah force-pushed the fix/coverage-report-when-coverpkg-is-used branch from bb12492 to f7cd72d Compare August 6, 2025 03:03
@ryancurrah ryancurrah changed the title fix(cmd/go): prevent stale coverage data when using -coverpkg with test caching fix(cmd/go): invalidate test cache when -coverpkg sources change Aug 6, 2025
@ryancurrah ryancurrah changed the title fix(cmd/go): invalidate test cache when -coverpkg sources change cmd/go: invalidate test cache when -coverpkg sources change Aug 6, 2025
@gopherbot
Copy link
Contributor

This PR (HEAD: f7cd72d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690775.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@ryancurrah ryancurrah mentioned this pull request Aug 6, 2025
Open
@gopherbot
Copy link
Contributor

Message from Ryan Currah:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/690775.
After addressing review feedback, remember to publish your drafts!

@ryancurrah ryancurrah force-pushed the fix/coverage-report-when-coverpkg-is-used branch from f7cd72d to cb64dbe Compare August 9, 2025 13:26
@ryancurrah ryancurrah changed the title cmd/go: invalidate test cache when -coverpkg sources change cmd/go: only invalidate coverage cache when coverpkg sources change Aug 9, 2025
@gopherbot
Copy link
Contributor

This PR (HEAD: cb64dbe) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690775.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@ryancurrah ryancurrah force-pushed the fix/coverage-report-when-coverpkg-is-used branch from cb64dbe to ca629f2 Compare August 9, 2025 13:33
@ryancurrah ryancurrah changed the title cmd/go: only invalidate coverage cache when coverpkg sources change cmd/go: only invalidate coverage report cache when coverpkg sources change Aug 9, 2025
@ryancurrah ryancurrah force-pushed the fix/coverage-report-when-coverpkg-is-used branch from ca629f2 to 5e0f1be Compare August 9, 2025 13:38
@gopherbot
Copy link
Contributor

This PR (HEAD: 5e0f1be) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690775.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@ryancurrah ryancurrah force-pushed the fix/coverage-report-when-coverpkg-is-used branch from 5e0f1be to d0fbeeb Compare August 9, 2025 13:42
@gopherbot
Copy link
Contributor

This PR (HEAD: d0fbeeb) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690775.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@ryancurrah
cmd/go: invalidate coverage report cache when coverpkg sources change
e85b4c0 
When using -coverpkg, test caching could return stale coverage data
if covered packages were modified but the test package itself was
unchanged. This occurred because the test cache didn't track changes
to packages specified by -coverpkg.

This change adds additional cache invalidation for coverage reports
by including covered package source file hashes in the coverage
profile cache key:

- Add hashCoveredPackages function to hash source files of covered packages
- Modify coverProfileAndInputKey to include covered packages hash
- Add test case to verify coverage report cache invalidation works correctly

Coverage reports are still invalidated when test packages change (as before),
and now also invalidated when any coverpkg-specified package changes,
improving cache accuracy while maintaining performance.

Fixes issue where coverage reports contained duplicate entries with
different line ranges after source modifications in covered packages.

Fixes golang#74873
@ryancurrah ryancurrah force-pushed the fix/coverage-report-when-coverpkg-is-used branch from d0fbeeb to e85b4c0 Compare August 9, 2025 14:07
@ryancurrah ryancurrah changed the title cmd/go: only invalidate coverage report cache when coverpkg sources change cmd/go: invalidate coverage report cache when coverpkg sources change Aug 9, 2025
@gopherbot
Copy link
Contributor

This PR (HEAD: e85b4c0) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690775.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cmd/go: test cache uses stale coverage data with -coverpkg
2 participants
@ryancurrah @gopherbot