Move lingering app fetches to remote functions, fix stream logging issue #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for soli-network ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
TL;DR I'm an idiot. Need to tighten things up and add some tests
frederickobrien
force-pushed
the
change-global-state-fetches-to-remote-functions
branch
from
e73bbf7 to
277a821
Compare
✅ Deploy Preview for soli-artists-dashboard canceled.
|
✅ Deploy Preview for soli-api canceled.
|
Merged
5 tasks
frederickobrien
deleted the
change-global-state-fetches-to-remote-functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR I'm an idiot. Need to tighten things up and add some tests. Hopefully this is the last piece of cleanup for #55. The root of a couple of issues was that I'd forgotten to update the user ID in the global state, causing a bunch of requests to fail.
Now seems to work though can certainly be improved.