-
-
Notifications
You must be signed in to change notification settings - Fork 0
Collections and Mixtapes #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for soli-network ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for soli-api ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for soli-artists-dashboard canceled.
|
It's so... beautiful
A step towards where I want to be but still more to do. This separates global state from props enough to make track tables far more reusable, as they should be, but the data model needs to be tidier
Attempting to get things working after #55. Looks like remote functions may have some issues around origin so hopefully this approach is temporary
|
A few teething issues mostly resolved by #58, #59, and #60. Remote functions don't seem to play nicely with CORS - sometimes the request origin of remote functions hitting the API is (wrongly) Setting the origin explicitly seems to have done the trick though it feels a bit gnarly. I've adjusted the local dev setup to seemingly mirror production behaviour, with the base domains changing depending on the environment but the checks always applied. |
This got a little bit out of hand. What started as a PR to add Collections (groups of albums) and Mixtapes (groups of songs) has also come to include remote functions and quite a hefty data types rejig.
Listeners can indeed now create, customise, and delete collections and mixtapes, with (for now pretty clunky) popups available on releases and tracks.
This also wound up being a nice excuse to try out Svelte's experimental new remote functions. Early days but I think I really, really like them. In tandem I've introduced Zod for form type checking and that whole side of things feels far more organised. There's still more to do but that can be work for another PR.
I also wound up trying to reorganise the underlying data types to make them easier to reason with. Now
Artist,Release,Track,Collection, andMixtapetypes can be mixed and maxed to form hydrated versions of themselves:In tandem with this I've moved a few more pieces of data to the global state rather than passing them around everywhere and muddying the waters.
Monster of a PR in the end, daft, but pleased with how Soli's feeling. All the base functionality is now more or less there.
A few screenshots
Followups