Delete vscode configuration settings.#1228
Delete vscode configuration settings.#1228copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
PiperOrigin-RevId: 760542016
|
@theo-brown as a TORAX developer from the open source repo, are these configuration settings useful to you/something you see value in keeping? |
|
They're useful, but perhaps don't need to be part of the source code? e.g. I could move them to a section of the docs. |
|
Good to know! (How) are you using them atm? |
|
They get auto-detected by VSCode and then used as the "workspace settings", ie applied to anything edited or saved within the TORAX directory tree. |
|
One thing to note: currently my autoformat is still in slight disagreement, despite using this config. Things I've noticed:
I can try and fix this and then move this to a page in the developer docs? |
If you are able to marry the mismatch that would be great! I'm a bit hesitant to move this to developer docs as I feel it would not be as discoverable there, it seems vscode is autopicking it up if it lives here which sounds ideal, wdyt? |
|
Once #1329 is merged I'll revisit this - the differences in formatting were probably due to missing the changes that are being added to pyproject.toml |
|
hi Theo, small update on this. 1329 is now in. A workflow of using |
|
If you could check when you have a moment given that workflow if these changes are still relevant that would be super, thanks! |
|
Closing in favour of #1346 |
Delete vscode configuration settings.