Update VSCode workspace settings#1346
Conversation
Nush395
added
the
copybara:import-manual
|
@Nush395 sorry hold your horses! Just discovered it's still being a bit greedy with sorting imports, eg
|
|
How did @mikesndrs fix this in the CI? Is this just a setting in pyproject.toml not being picked up correctly by VSCode? |
|
Oops, sorry, this was set to autosubmit and I approved it before I noticed your message. Can open another PR with refinements to fix the "greedy import" issue. @mikesndrs and @Nush395 can comment on the workaround. |
|
Sorry Theo, assumed this was all good to go! I believe Mike's workflow is to use: I'm not familiar with these VSCode settings files, might be a question for Gemini. Will tal myself tomorrow as well :) |
|
No, it's also my fault! It's quite hard to check that isort's doing the right thing, and I just hadn't checked this pattern. |
3 participants
#1228 aimed to delete these settings. Following discussions with @Nush395, we decided to keep them in. After the merging of #1329, I revisited the vscode settings to make sure all was working ok. I removed a few unused lines in the settings and added pylint as a recommended extension.