-
Notifications
You must be signed in to change notification settings - Fork 10.5k
fix(patch): cherry-pick 07e597d to release/v0.22.4-pr-15684 [CONFLICTS] #15733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(patch): cherry-pick 07e597d to release/v0.22.4-pr-15684 [CONFLICTS] #15733
Conversation
#15684) # Conflicts: # packages/core/src/utils/retry.ts
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated as a cherry-pick, updates the handling of Google quota errors by removing a fixed 5-second default retry delay. The change makes the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request cherry-picks a fix to remove the default retry delay for generic 429 quota errors, instead relying on exponential backoff when no specific delay is provided by the API. However, a critical issue was found in packages/core/src/utils/retry.ts where unresolved merge conflicts are present, which will cause the application to crash and must be resolved before merging. The rest of the changes do not appear to introduce security vulnerabilities.
|
Size Change: +180 B (0%) Total Size: 21.6 MB ℹ️ View Unchanged
|
This PR automatically cherry-picks commit 07e597d to patch version v0.22.4 in the stable release to create version 0.22.5.
This cherry-pick resulted in merge conflicts that need manual resolution.
🔧 Next Steps:
📋 Files with conflicts:
The commit has been created with conflict markers for easier manual resolution.
🚨 Important: