fix: incorrect settings format in mcp add command

[subhobhai943]

Closing as duplicate of #15465.

[gemini-code-assist]

Summary of Changes

Hello @subhobhai943, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical configuration issue within the gemini mcp add command. The change ensures that when an HTTP transport is specified, the generated settings.json entry adheres to the expected schema, preventing validation failures and ensuring proper functionality of the added server configuration.

Highlights

• Configuration Fix for gemini mcp add: Corrected the gemini mcp add command to properly format HTTP transport settings in settings.json. Previously, it incorrectly wrote url and type: 'http', which caused validation errors. Now, it correctly uses httpUrl as expected by the schema.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This PR correctly fixes a validation error when adding an MCP server with HTTP transport. The change to use httpUrl aligns the add command with the configuration schema's expectations.

However, there is a critical omission: the corresponding unit tests in packages/cli/src/commands/mcp/add.test.ts have not been updated. The tests for adding an HTTP server will now fail because they still assert the old configuration format. It is essential to update these tests to reflect the new behavior to ensure the fix is correctly verified and to maintain the integrity of the test suite.

[gemini-code-assist]

While this change correctly fixes the validation bug, it uses the httpUrl property which is marked as deprecated in MCPServerConfig. The preferred modern approach is using url with type: 'http'. This highlights an inconsistency between the CLI's validation schema and the core library's design. This fix is acceptable, but a follow-up issue should be created to align the schema and migrate away from the deprecated httpUrl property to prevent future maintenance issues.

[jackwotherspoon]

@subhobhai943 Appreciate the PR but this has already been fixed in main, just isn't in stable release.

Fix PR: #15465

[subhobhai943]

Thanks @jackwotherspoon for the heads up! I see now that this was addressed in #15465. I'll close this PR since it's redundant.