Skip to content

fix: incorrect settings format in mcp add command #16180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
subhobhai943 wants to merge 3 commits into from
Closed

fix: incorrect settings format in mcp add command #16180

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e23238d
fix: use httpUrl and remove type for http transport in mcp add command
subhobhai943 Jan 8, 2026
12f614e
Merge branch 'main' into fix/mcp-add-settings-format
subhobhai943 Jan 8, 2026
50147e1
Merge branch 'main' into fix/mcp-add-settings-format
subhobhai943 Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/cli/src/commands/mcp/add.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,7 @@ async function addMcpServer(
break;
case 'http':
newServer = {
url: commandOrUrl,
type: 'http',
httpUrl: commandOrUrl,
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this change correctly fixes the validation bug, it uses the httpUrl property which is marked as deprecated in MCPServerConfig. The preferred modern approach is using url with type: 'http'. This highlights an inconsistency between the CLI's validation schema and the core library's design. This fix is acceptable, but a follow-up issue should be created to align the schema and migrate away from the deprecated httpUrl property to prevent future maintenance issues.

headers,
timeout,
trust,
Expand Down