Skip to content

Modify components to allow application of more expressive styling.#772

Open
jgindin wants to merge 7 commits intogoogle:mainfrom
jgindin:update-components-for-styling
Open

Modify components to allow application of more expressive styling.#772
jgindin wants to merge 7 commits intogoogle:mainfrom
jgindin:update-components-for-styling

Conversation

@jgindin
Copy link
Collaborator

@jgindin jgindin commented Mar 4, 2026

Description

A few components needed some tweaks in order to apply a new theme.

There is no change to these components when using existing themes.

Pre-launch Checklist

  • [x ] I signed the CLA.
  • [ x] I read the Contributors Guide.
  • [ x] I read the Style Guide.
  • I have added updates to the CHANGELOG.
  • [ x] I updated/added relevant documentation.
  • [ x] My code changes (if any) have tests.

There is no change to these components when using existing themes.
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the List, Slider, and Tabs components to support more expressive styling. While the changes introduce useful features and refactorings, there are a few issues to address. Most importantly, tests are missing for the new changes, which is required by the repository's contribution guidelines. Additionally, there are opportunities to improve type safety in the List component by avoiding $any(), and to reduce code duplication in the Slider component. I've also noted a minor formatting issue. Please see the specific comments for details.

Comment on lines +38 to +39
display: flex;
flex-direction: column;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The repository style guide requires tests for code changes. While the PR description checklist for tests is marked as complete, I don't see any new or updated tests in this pull request. Please add unit tests to cover the new logic and behavior introduced in the List, Slider, and Tabs components.

References
  1. If there are code changes, code should have tests. (link)

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@jgindin jgindin marked this pull request as draft March 4, 2026 21:06
@jgindin jgindin marked this pull request as ready for review March 4, 2026 23:12
Copy link
Collaborator

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions about some of the "hardcoded" classnames for the elements

@jgindin jgindin requested a review from ditman March 5, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants