-
Notifications
You must be signed in to change notification settings - Fork 890
Modify components to allow application of more expressive styling. #772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 5 commits
5bd1c5d
5897b50
08c7ca3
2c5f544
9cc6bb0
aeb3c7c
4aead0a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,7 +35,8 @@ import { Renderer } from '../rendering/renderer'; | |
| } | ||
|
|
||
| :host([direction='vertical']) section { | ||
| display: grid; | ||
| display: flex; | ||
| flex-direction: column; | ||
|
Comment on lines
+38
to
+39
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The repository style guide requires tests for code changes. While the PR description checklist for tests is marked as complete, I don't see any new or updated tests in this pull request. Please add unit tests to cover the new logic and behavior introduced in the References
|
||
| } | ||
|
|
||
| :host([direction='horizontal']) section { | ||
|
|
@@ -44,17 +45,21 @@ import { Renderer } from '../rendering/renderer'; | |
| overflow-x: scroll; | ||
| overflow-y: hidden; | ||
| scrollbar-width: none; | ||
| } | ||
|
|
||
| > ::slotted(*) { | ||
| flex: 1 0 fit-content; | ||
| max-width: min(80%, 400px); | ||
| } | ||
| .a2ui-list-item { | ||
| display: flex; | ||
| align-items: center; | ||
jgindin marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| cursor: pointer; | ||
| box-sizing: border-box; | ||
| } | ||
| `, | ||
| template: ` | ||
| <section [class]="theme.components.List" [style]="theme.additionalStyles?.List"> | ||
| @for (child of component().properties.children; track child) { | ||
| <ng-container a2ui-renderer [surfaceId]="surfaceId()!" [component]="child" /> | ||
| <div class="a2ui-list-item"> | ||
| <ng-container a2ui-renderer [surfaceId]="surfaceId()!" [component]="child" /> | ||
| </div> | ||
| } | ||
| </section> | ||
| `, | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.