[rewrite] Add `Java8toJava11` #5328

Pankraz76 · 2025-11-08T13:34:15Z

related to:

Pankraz76 · 2025-11-08T13:35:40Z

check_api/src/main/java/com/google/errorprone/fixes/SuggestedFixes.java

  }

  private static @Nullable Tree suppressibleNode(TreePath path, VisitorState state) {
-    return StreamSupport.stream(path.spliterator(), false)


https://error-prone.picnic.tech/refasterrules/StreamRules/

If there is interest in using (a subset of) our Refaster rules, IMO it'd make more sense to directly import them from Error Prone Support, instead of going via OpenRewrite.

CC: @Stephan202

Pankraz76 · 2025-11-08T13:36:09Z

check_api/pom.xml

    </dependency>
+    <dependency>
+      <groupId>jakarta.inject</groupId>
+      <artifactId>jakarta.inject-api</artifactId>


java migration

I'm not sure what this means, why was this change made?

yes this is kind of new to everyone but seems best practise:

https://docs.openrewrite.org/recipes/java/migrate/javax/addcommonannotationsdependencies

its needed as part of upcomming javax to jakarta bump, so its kind of required:

PRO tip: here its not included due to maven ignorance but this is kind of bug it system design.

Issue #17487: fix skipMavenParsing checkstyle/checkstyle#18005

Issue #17487: Add Rewrite:UpgradeToJava17 checkstyle/checkstyle#17730

pom.xml

cushon

Were all of the changes in this PR generated by openrewrite using the rewrite.yml config you added?

Some of them look unrelated, like the formatting changes to the pom.xml files and some of the Java files.

Pankraz76 · 2025-11-10T11:58:15Z

yes sorry its all related to some individual recipe.

Im going to supplement and extract to make it transparent and mergeable.

Thank you.

rickie

Some thoughts :)

rickie · 2025-11-10T13:26:56Z

rewrite.yml

+displayName: Apply Java & Maven best practices
+description: Comprehensive code quality recipe combining modernization, security, and best practices.
+recipeList:
+  - org.openrewrite.java.RemoveUnusedImports


There already exists an Error Prone check for this.

yes, also all tools have bugs and or different perspectives, never say never.

[rewrite] Add GradleBestPractices opensearch-project/OpenSearch#19885 (comment)

rickie · 2025-11-10T13:27:32Z

rewrite.yml

+recipeList:
+  - org.openrewrite.java.RemoveUnusedImports
+  - org.openrewrite.java.format.NormalizeLineBreaks
+  - org.openrewrite.java.format.RemoveTrailingWhitespace


Would say this cannot occur given the use of Google Java Format.

yes, also all tools have bugs and or different perspectives, never say never.

[rewrite] Add GradleBestPractices opensearch-project/OpenSearch#19885 (comment)

spot uses google or palant which is google. (zero trust principle)

Pankraz76 · 2025-11-10T17:39:51Z

Some thoughts :)

always helpful and welcome.

Let me know if something to adjust, kind regards.

Pankraz76 · 2025-11-12T12:40:16Z

thanks for the fixup.

rebase:

[INFO] Running recipe(s)...
[INFO] Printing available datatables to: target/rewrite/datatables/2025-11-12_13-25-51-096
[WARNING] The recipe produced 5 warning(s). Please report this to the recipe author.
[WARNING] Changes have been made to check_api/pom.xml by:
[WARNING]     org.openrewrite.java.migrate.Java8toJava11
[WARNING]         org.openrewrite.java.migrate.javax.AddInjectDependencies
[WARNING]             org.openrewrite.java.dependencies.AddDependency: {groupId=jakarta.inject, artifactId=jakarta.inject-api, version=1.0.3, onlyIfUsing=javax.inject.*, acceptTransitive=true}
[WARNING]         org.openrewrite.java.migrate.javax.AddCommonAnnotationsDependencies
[WARNING]             org.openrewrite.java.dependencies.AddDependency: {groupId=jakarta.annotation, artifactId=jakarta.annotation-api, version=1.3.x, onlyIfUsing=javax.annotation..*, scope=provided, acceptTransitive=true}
[WARNING] Changes have been made to check_api/src/main/java/com/google/errorprone/apply/DescriptionBasedDiff.java by:
[WARNING]     org.openrewrite.java.migrate.Java8toJava11
[WARNING]         org.openrewrite.java.migrate.nio.file.PathsGetToPathOf
[WARNING]             org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path}
[WARNING]             org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of}
[WARNING] Changes have been made to core/pom.xml by:
[WARNING]     org.openrewrite.java.migrate.Java8toJava11
[WARNING]         org.openrewrite.java.migrate.javax.AddInjectDependencies
[WARNING]             org.openrewrite.java.dependencies.AddDependency: {groupId=jakarta.inject, artifactId=jakarta.inject-api, version=1.0.3, onlyIfUsing=javax.inject.*, acceptTransitive=true}
[WARNING]         org.openrewrite.java.migrate.javax.AddCommonAnnotationsDependencies
[WARNING]             org.openrewrite.java.dependencies.AddDependency: {groupId=jakarta.annotation, artifactId=jakarta.annotation-api, version=1.3.x, onlyIfUsing=javax.annotation..*, scope=provided, acceptTransitive=true}
[WARNING] Changes have been made to core/src/main/java/com/google/errorprone/bugpatterns/checkreturnvalue/ExternalCanIgnoreReturnValue.java by:
[WARNING]     org.openrewrite.java.migrate.Java8toJava11
[WARNING]         org.openrewrite.java.migrate.nio.file.PathsGetToPathOf
[WARNING]             org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path}
[WARNING]             org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of}
[WARNING] Changes have been made to core/src/test/java/com/google/errorprone/ErrorProneJavacPluginTest.java by:
[WARNING]     org.openrewrite.java.migrate.Java8toJava11
[WARNING]         org.openrewrite.java.migrate.nio.file.PathsGetToPathOf
[WARNING]             org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path}
[WARNING]             org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of}
[WARNING] Changes have been made to core/src/test/java/com/google/errorprone/bugpatterns/apidiff/CompilationBuilderHelpers.java by:
[WARNING]     org.openrewrite.java.migrate.Java8toJava11
[WARNING]         org.openrewrite.java.migrate.nio.file.PathsGetToPathOf
[WARNING]             org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path}
[WARNING]             org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of}
[WARNING] Changes have been made to docgen_processor/pom.xml by:
[WARNING]     org.openrewrite.java.migrate.Java8toJava11
[WARNING]         org.openrewrite.java.migrate.javax.AddCommonAnnotationsDependencies
[WARNING]             org.openrewrite.java.dependencies.AddDependency: {groupId=jakarta.annotation, artifactId=jakarta.annotation-api, version=1.3.x, onlyIfUsing=javax.annotation..*, scope=provided, acceptTransitive=true}
[WARNING] Changes have been made to docgen/src/main/java/com/google/errorprone/DocGenTool.java by:
[WARNING]     org.openrewrite.java.migrate.Java8toJava11
[WARNING]         org.openrewrite.java.migrate.nio.file.PathsGetToPathOf
[WARNING]             org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path}
[WARNING]             org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of}
[WARNING] Changes have been made to docgen/src/main/java/com/google/errorprone/BugPatternFileGenerator.java by:
[WARNING]     org.openrewrite.java.migrate.Java8toJava11
[WARNING]         org.openrewrite.java.migrate.nio.file.PathsGetToPathOf
[WARNING]             org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path}
[WARNING]             org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of}
[WARNING] Please review and commit the results.
[WARNING] Estimate time saved: 45m
[INFO] ------------------------------------------------------------------------

Signed-off-by: Vincent Potucek <[email protected]>

Pankraz76 mentioned this pull request Nov 8, 2025

Add rewrite support for errorprone.refasterrules #5195

Open

Pankraz76 commented Nov 8, 2025

View reviewed changes

Pankraz76 force-pushed the pr-rewrite branch from fd87029 to d69eb5f Compare November 8, 2025 13:38

Pankraz76 marked this pull request as ready for review November 8, 2025 13:38

Pankraz76 mentioned this pull request Nov 10, 2025

[rewrite] Add RemoveUnusedImports keycloak/keycloak#44043

Closed

cushon requested changes Nov 10, 2025

View reviewed changes

rickie reviewed Nov 10, 2025

View reviewed changes

Pankraz76 force-pushed the pr-rewrite branch from d69eb5f to 8749941 Compare November 10, 2025 17:26

Pankraz76 changed the title ~~[openrewrite] initial merge and Java8toJava11~~ [rewrite] Add Java8toJava11 Nov 10, 2025

Pankraz76 requested review from cushon and rickie November 10, 2025 17:33

Pankraz76 force-pushed the pr-rewrite branch from 8749941 to 86da496 Compare November 10, 2025 17:36

This was referenced Nov 11, 2025

[rewrite] Add Java8toJava11 Pankraz76/spring-framework#3

Merged

Add rewrite support for errorprone.refasterrules spring-projects/spring-framework#35270

Closed

Pankraz76 force-pushed the pr-rewrite branch from 86da496 to bc4bed3 Compare November 12, 2025 12:39

[rewrite] Add Java8toJava11

6896381

Signed-off-by: Vincent Potucek <[email protected]>

Pankraz76 force-pushed the pr-rewrite branch from bc4bed3 to 6896381 Compare November 12, 2025 12:42

Pankraz76 mentioned this pull request Nov 12, 2025

[rewrite] Add UpdateMavenWrapper #5343

Open

[rewrite] Add Java8toJava11 #5328

Are you sure you want to change the base?

[rewrite] Add Java8toJava11 #5328

Uh oh!

Conversation

Pankraz76 commented Nov 8, 2025

Uh oh!

Pankraz76 Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

rickie Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Pankraz76 Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

cushon Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Pankraz76 Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Pankraz76 Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cushon left a comment

Choose a reason for hiding this comment

Uh oh!

Pankraz76 commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickie left a comment

Choose a reason for hiding this comment

Uh oh!

rickie Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Pankraz76 Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rickie Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Pankraz76 Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pankraz76 commented Nov 10, 2025

Uh oh!

Pankraz76 commented Nov 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[rewrite] Add `Java8toJava11` #5328

[rewrite] Add `Java8toJava11` #5328

Pankraz76 Nov 12, 2025 •

edited

Loading

Pankraz76 commented Nov 10, 2025 •

edited

Loading

Pankraz76 Nov 10, 2025 •

edited

Loading

Pankraz76 Nov 10, 2025 •

edited

Loading