github: renderdiff ensure right clang#9816
Merged
Conversation
poweifeng
force-pushed
the
pf/github-fix-rdiff2
branch
3 times, most recently
from
04f0aac to
28afa5b
Compare
For renderdiff, we compile mesa using brew's llvm/clang, but we compile gltf_viewer using the system clang (AppleClang). This is to prevent compiling filament with brew's clang (which can cause unexpected compilation error).
poweifeng
force-pushed
the
pf/github-fix-rdiff2
branch
from
28afa5b to
62c3f43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For renderdiff, we compile mesa using brew's llvm/clang, but we compile gltf_viewer using the system clang (AppleClang).
This is to prevent compiling filament with brew's clang (which can cause unexpected compilation error).