-
Notifications
You must be signed in to change notification settings - Fork 102
Update outdated contributing guidelines, specially the local setup and monorepo migration documentation #2404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update outdated contributing guidelines, specially the local setup and monorepo migration documentation #2404
Conversation
…d monorepo documentation
Summary of ChangesHello @sidd190, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request updates the contributing guidelines, focusing on local setup and monorepo migration documentation. The changes include updating Node.js versions, global tool installations, and commands for running and deploying the application. The documentation is now more current and accurate, which will greatly assist new and existing contributors.
gino-m
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most content in this file is a duplicate of what's in README.md. Can we please remove that content and refer to README.md instead?
Like do i just remove the content and keep only the headers and mention to refer to the readme for setting the codebase up locally, for example? |
You can replace lines 67-130 in the original file with a reference to README.md, e.g,: |
Donee! Sorry I got stuck with uni assignments a bit. |
gino-m
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done, thanks for the fix!
This PR updates the contributing guidelines for setting up the codebase locally and other outdated versions and commands mentioned.
No issue is open for this.