Skip to content

Add upper filter (to support inclusionAI/Ling-Coder-lite)#58

Merged
ochafik merged 3 commits intomainfrom
upper
Mar 31, 2025
Merged

Add upper filter (to support inclusionAI/Ling-Coder-lite)#58
ochafik merged 3 commits intomainfrom
upper

Conversation

@ochafik
Copy link
Copy Markdown
Contributor

@ochafik ochafik commented Mar 30, 2025

cc/ @CISC (ref)

@ochafik ochafik marked this pull request as ready for review March 30, 2025 22:31
@ochafik ochafik changed the title Add upper filter (to support inclusionAI/Ling-Coder-lite) Add upper filter (to support inclusionAI/Ling-Coder-lite) Mar 30, 2025
@ochafik ochafik merged commit 84187ba into main Mar 31, 2025
11 checks passed
@ochafik ochafik deleted the upper branch March 31, 2025 00:59
@CISC
Copy link
Copy Markdown

CISC commented Mar 31, 2025

Ah, didn't even occur to me that this wasn't already implemented. :D

BTW (related to the original llama.cpp feedback), why is the chat template being parsed even when --jinja is not specified?

ochafik added a commit to ggml-org/llama.cpp that referenced this pull request May 15, 2025
* minja: sync google/minja@f06140f

- google/minja#67 (@grf53)
- google/minja#66 (@taha-yassine)
- google/minja#63 (@grf53)
- google/minja#58

---------

Co-authored-by: ochafik <ochafik@google.com>
justinryan-0923 pushed a commit to justinryan-0923/llama.cpp that referenced this pull request May 30, 2025
* minja: sync google/minja@f06140f

- google/minja#67 (@grf53)
- google/minja#66 (@taha-yassine)
- google/minja#63 (@grf53)
- google/minja#58

---------

Co-authored-by: ochafik <ochafik@google.com>
ochafik added a commit to ochafik/minja that referenced this pull request Nov 2, 2025
* Add upper filter

* Test inclusionAI/Ling-Coder-lite template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants