Fix null content for chat-template.#75
Merged
ochafik merged 1 commit intogoogle:mainfrom Jul 11, 2025
Merged
Conversation
The nullptr cause `Test failed: basic_string: construction from null is not valid`. Change to use json j_null instead. Tests pass with `./scripts/tests.sh`
yatarkan
approved these changes
Jul 10, 2025
Contributor
Author
|
@ochafik for review |
ochafik
approved these changes
Jul 11, 2025
ochafik
pushed a commit
to ochafik/minja
that referenced
this pull request
Nov 2, 2025
The nullptr cause `Test failed: basic_string: construction from null is not valid`. Change to use json j_null instead. Tests pass with `./scripts/tests.sh`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
nullptrcauseTest failed: basic_string: construction from null is not valid.The root cause is the ternary operator of
std::stringandnullptrhttps://softwareengineering.stackexchange.com/questions/450335/is-it-bad-practice-to-use-nullptr-in-ternary-operation
Change to use empty
jsonj_nullinstead.https://json.nlohmann.me/api/basic_json/is_null/
Tests pass with
./scripts/tests.sh