fix: add per-service apiVersion to gapic_metadata #1239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viacheslav-rostovtsev
previously approved these changes
Nov 5, 2025
noahdietz
added
the
automerge
noahdietz
removed
the
automerge
noahdietz
force-pushed
the
gapic-metadata-api-version
branch
from
bf0f352 to
4c5f0c8
Compare
viacheslav-rostovtsev
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Populates the
api_versionfield on a per-servicebasis to the generatedgapic_metadata.jsonusing the value from theservice-level annotationgoogle.api.api_versionalready parsed for use in theX-Goog-Api-Version/$apiVersionsystem parameter (as of #1074).Showcase-based tests already have
google.api.api_versionset onservice Echo, so the baselines are appropriately updated to account for inclusion ofapiVersionin thegapic_metadata.jsonoutput.It's presence in
gapic_metadata.jsonwill allow parsers to correlateserviceclient to API version. It is not in use by any API yet. Only the unit tests needed updating.Internal bug http://b/452365074.