Skip to content

fix: add per-service apiVersion to gapic_metadata #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
viacheslav-rostovtsev merged 5 commits into from
Nov 6, 2025
Merged

fix: add per-service apiVersion to gapic_metadata #1239

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e299e90
fix: add per-service apiVersion to gapic_metadata
noahdietz Nov 5, 2025
de89990
Merge branch 'main' into gapic-metadata-api-version
noahdietz Nov 5, 2025
c8988fa
use unless instead of if
noahdietz Nov 5, 2025
4c5f0c8
use unless instead of if for real this time
noahdietz Nov 5, 2025
17ca0b6
go back to variable and conditional add
noahdietz Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion gapic-generator/lib/gapic/presenters/service_presenter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@ def grpc_full_name
#
# @return [Hash]
def drift_manifest
{
h = {
clients: {
grpc: {
libraryClient: client_name_full,
Expand All @@ -538,6 +538,11 @@ def drift_manifest
}
}
}
if !@service.api_version.empty?
h[:apiVersion] = @service.api_version
end

return h
end

##
Expand Down
3 changes: 2 additions & 1 deletion shared/output/gapic/templates/showcase/gapic_metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,8 @@
}
}
}
}
},
"apiVersion": "v1_20240408"
},
"Identity": {
"clients": {
Expand Down
Loading