fix(test): address flaky healthcare integration test run

[helloeve]

This PR introduces an auto-cleanup mechanism to address flakiness in the Cloud Healthcare integration tests caused by accumulation of orphaned resources (arising from abrupt CI terminations or local cancellations).

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the stability of Cloud Healthcare integration tests by implementing a robust pre-test cleanup mechanism. It ensures that tests run in a clean environment by automatically identifying and deleting any previously created, but not properly removed, FHIR and DICOM stores. This prevents test failures due to resource conflicts or accumulation from prior, potentially aborted, test runs.

Highlights

• Automated Resource Cleanup: Introduced a TestMain function to automatically clean up orphaned Cloud Healthcare FHIR and DICOM stores older than 2 hours before test execution, addressing flakiness caused by leftover resources.
• Resource Tracking: Implemented a created_at label for newly created FHIR and DICOM stores, storing their Unix timestamp to facilitate age-based cleanup.

Changelog

• tests/cloudhealthcare/cloud_healthcare_integration_test.go
  • Imported the strconv package for string to integer conversions.
  • Added a TestMain function to orchestrate pre-test cleanup of orphaned resources.
  • Implemented the cleanupOrphanedStores function to list and delete FHIR and DICOM stores based on their creation timestamp.
  • Modified the setupHealthcareResources function to add a created_at label with the current Unix timestamp to newly created FHIR and DICOM stores.

Activity

• No specific activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces an auto-cleanup mechanism for orphaned Cloud Healthcare resources to improve the reliability of integration tests. This is a good approach to address test flakiness. The implementation adds a created_at label to newly created resources and uses a TestMain function to trigger cleanup of old resources before tests run. My feedback focuses on improving the robustness and readability of the cleanup logic by adding error logging, using more descriptive constants for time durations, and reducing code duplication.

[Yuan325]

I created 2 dummy data stores (temporary-fhir for fhir store and temporary-testing-data for DICOM store) with created_at : 1257885000 but it doesn't seem like the integration tests are removing them.

[helloeve]

@Yuan325 the cleanup logic will attempt to delete stores with prefix dicom-store- or fhir-store- so the temp ones your created won't be deleted. I tested for a manual created one with fhir-store-temporary-test and it was deleted successfully.

[Yuan325]

/gcbrun