feat: Support scopes from JSON for Impersonated Credentials #3059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertvoinescu-work
force-pushed
the
users/robertvoinescu/impersonated_credential_scopes
branch
from
4331162 to
4c8b268
Compare
robertvoinescu-work
force-pushed
the
users/robertvoinescu/impersonated_credential_scopes
branch
3 times, most recently
from
93afb1e to
bdd0b84
Compare
amanda-tarafa
requested changes
Oct 16, 2025
Contributor
amanda-tarafa
left a comment
amanda-tarafa
left a comment
There was a problem hiding this comment.
A couple of minor changes, but this looks great, thanks.
Src/Support/Google.Apis.Auth.Tests/OAuth2/GoogleCredentialTests.cs
Outdated
Show resolved
Hide resolved
robertvoinescu-work
force-pushed
the
users/robertvoinescu/impersonated_credential_scopes
branch
from
bdd0b84 to
5b5c6fe
Compare
robertvoinescu-work
force-pushed
the
users/robertvoinescu/impersonated_credential_scopes
branch
from
5b5c6fe to
586d1d9
Compare
When using an impersonated service account, scopes specified in the JSON file were previously ignored. This change updates the `CredentialFactory` to read the `scopes` array from the impersonated credential configuration. Programmatically set scopes via `CreateScoped` will continue to take precedence over the scopes defined in the JSON file.
robertvoinescu-work
force-pushed
the
users/robertvoinescu/impersonated_credential_scopes
branch
from
586d1d9 to
1008f57
Compare
robertvoinescu-work
deleted the
users/robertvoinescu/impersonated_credential_scopes
branch
robertvoinescu-work
added a commit
to robertvoinescu-work/google-api-dotnet-client
that referenced
this pull request
Nov 18, 2025
Features: - googleapis#3064 Introduces methods to create a google credential by specifying the type and either a path to the credential or the credential as a json string. - googleapis#3059 Support loading scopes of impersonated credentials from file.
robertvoinescu-work
added a commit
to robertvoinescu-work/google-api-dotnet-client
that referenced
this pull request
Nov 18, 2025
Features: - googleapis#3064 Adds methods to load a credential by specifying the type and either file path or json string. - googleapis#3059 Supports loading scopes for impersonated credentials from new optional `scopes` field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an impersonated service account, scopes specified in the JSON file were previously ignored.
This change updates the
CredentialFactoryto read thescopesarray from the impersonated credential configuration. Programmatically set scopes viaCreateScopedwill continue to take precedence over the scopes defined in the JSON file.b/450323529