chore(tests): allow expired secret in system tests #1883
Conversation
Summary of ChangesHello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a short-term fix to prevent system tests from failing due to expired Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a workaround to the system tests to ignore RefreshError for expired authorized user credentials, unblocking other work. The changes are applied to both synchronous and asynchronous tests. My review identifies a potential AttributeError in the new logic in both modified files, which could occur if the GOOGLE_APPLICATION_CREDENTIALS environment variable is not set. I've provided code suggestions to fix this potential crash.
Updated `system_tests/system_tests_sync/test_default.py` and `system_tests/system_tests_async/test_default.py` to catch `RefreshError` and check for "invalid_grant" in the error message when running with `authorized_user.json` credentials. This allows the test to pass by confirming the library correctly received the error from the server, acknowledging that the CI credentials are often stale. This builds on @daniel-sanche' work in [PR #1883](https://togithub.com/googleapis/google-auth-library-python/pull/1883). Recent changes to `main` appear to have adjusted the response values in these tests and was leading to them failing during CI/CD presubmit tests ([see example below](https://togithub.com/googleapis/google-auth-library-python/pull/1901#issuecomment-3682277336)). This update now prevents those failing tests. --- *PR created automatically by Jules for task [5370487295365926138](https://jules.google.com/task/5370487295365926138) started by @chalmerlowe*
2 participants
Allow system tests to pass, even if the secret is found to be expired
Long term, we should re-think these tests. But this will unblock work in this repo
Context: #1882