Skip to content

chore(tests): allow expired secret in system tests #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-sanche merged 3 commits into from
Dec 4, 2025
Merged

chore(tests): allow expired secret in system tests #1883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35627dd
chore(tests): allow expired secret in system tests
daniel-sanche Dec 4, 2025
4537a78
check error string
daniel-sanche Dec 4, 2025
6a7f20c
make credentials always string
daniel-sanche Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions system_tests/system_tests_async/test_default.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,11 @@
import pytest

from google.auth import _default_async
from google.auth.exceptions import RefreshError

EXPECT_PROJECT_ID = os.getenv("EXPECT_PROJECT_ID")
CREDENTIALS = os.getenv("GOOGLE_APPLICATION_CREDENTIALS", "")

EXPECT_PROJECT_ID = os.environ.get("EXPECT_PROJECT_ID")

@pytest.mark.asyncio
async def test_application_default_credentials(verify_refresh):
Expand All @@ -26,4 +29,10 @@ async def test_application_default_credentials(verify_refresh):
if EXPECT_PROJECT_ID is not None:
assert project_id is not None

await verify_refresh(credentials)
try:
await verify_refresh(credentials)
except RefreshError as e:
# allow expired credentials for explicit_authorized_user tests
# TODO: https://github.com/googleapis/google-auth-library-python/issues/1882
if not CREDENTIALS.endswith("authorized_user.json") or "Token has been expired or revoked" not in str(e):
raise
12 changes: 10 additions & 2 deletions system_tests/system_tests_sync/test_default.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,10 @@
import os

import google.auth
from google.auth.exceptions import RefreshError

EXPECT_PROJECT_ID = os.environ.get("EXPECT_PROJECT_ID")
EXPECT_PROJECT_ID = os.getenv("EXPECT_PROJECT_ID")
CREDENTIALS = os.getenv("GOOGLE_APPLICATION_CREDENTIALS", "")


def test_application_default_credentials(verify_refresh):
Expand All @@ -25,4 +27,10 @@ def test_application_default_credentials(verify_refresh):
if EXPECT_PROJECT_ID is not None:
assert project_id is not None

verify_refresh(credentials)
try:
verify_refresh(credentials)
except RefreshError as e:
# allow expired credentials for explicit_authorized_user tests
# TODO: https://github.com/googleapis/google-auth-library-python/issues/1882
if not CREDENTIALS.endswith("authorized_user.json") or "Token has been expired or revoked" not in str(e):
raise