impl(bigtable): Add support for inserting tags into InstanceConfig #14920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
as a 
product-auto-label
bot
added
the
api: bigtable
Member
|
/gcbrun |
Member
|
It looks like the We can discuss over email what to do about this. I am going to close this PR. It is easy enough to hit the reopen button if/when a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
insert_tag()helper function toInstanceConfig.This is needed to support Bigtable's upcoming feature to allow tagging an instance on creation. Our tests require a method to add the tags information to the instance proto, and this using this library is how we achieve that.
This change is