Skip to content

impl(bigtable): Add support for inserting tags into InstanceConfig #14920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 1 commit into from
Closed

impl(bigtable): Add support for inserting tags into InstanceConfig #14920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions google/cloud/bigtable/instance_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,11 @@ class InstanceConfig {
return *this;
}

InstanceConfig& insert_tag(std::string const& key, std::string const& value) {
(*proto_.mutable_instance()->mutable_tags())[key] = value;
return *this;
}

// NOLINT: accessors can (and should) be snake_case.
google::bigtable::admin::v2::CreateInstanceRequest const& as_proto() const& {
return proto_;
Expand Down
17 changes: 17 additions & 0 deletions google/cloud/bigtable/instance_config_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,23 @@ TEST(InstanceConfigTest, SetLabels) {
EXPECT_EQ("qux", proto.instance().labels().at("baz"));
}

TEST(InstanceConfigTest, InsertTags) {
InstanceConfig config("my-instance", "pretty name",
{
{"cluster-1", {"somewhere", 7, ClusterConfig::SSD}},
});

config.insert_tag("tag_key", "tag_value");

auto proto = config.as_proto();
EXPECT_EQ("my-instance", proto.instance_id());
EXPECT_EQ("pretty name", proto.instance().display_name());
ASSERT_EQ(1, proto.clusters_size());

ASSERT_EQ(1, proto.instance().tags_size());
EXPECT_EQ("tag_value", proto.instance().tags().at("tag_key"));
}

} // namespace
GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace bigtable
Expand Down
Loading