impl: add experimental client SSL certificate support #15062
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15062 +/- ##
========================================
Coverage 92.90% 92.90%
========================================
Files 2354 2356 +2
Lines 210365 210507 +142
========================================
+ Hits 195442 195576 +134
- Misses 14923 14931 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| /** | ||
| * Represents an SSL certificate used in TLS authentication. | ||
| */ | ||
| class SslCertificate { |
There was a problem hiding this comment.
Nice idea to encapsulate the properties in a class.
There was a problem hiding this comment.
I did so hoping that we can reuse this for future features.
google/cloud/internal/curl_impl.cc
Outdated
| if (!status.ok()) return OnTransferError(context, std::move(status)); | ||
| } | ||
|
|
||
| #if CURL_AT_LEAST_VERSION(7, 71, 0) |
There was a problem hiding this comment.
Should this issue some kind of warning if the version is below the threshold?
There was a problem hiding this comment.
I added an error if they try and use this feature with an older version of libcurl
scotthart
left a comment
scotthart
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 10 files reviewed, 2 unresolved discussions (waiting on @ddelgrosso1)
| /** | ||
| * Represents an SSL certificate used in TLS authentication. | ||
| */ | ||
| class SslCertificate { |
There was a problem hiding this comment.
I did so hoping that we can reuse this for future features.
google/cloud/internal/curl_impl.cc
Outdated
| if (!status.ok()) return OnTransferError(context, std::move(status)); | ||
| } | ||
|
|
||
| #if CURL_AT_LEAST_VERSION(7, 71, 0) |
There was a problem hiding this comment.
I added an error if they try and use this feature with an older version of libcurl
scotthart
force-pushed
the
mtls_blob_option_rest
branch
from
cf1a75e to
ad41e2e
Compare
scotthart
force-pushed
the
mtls_blob_option_rest
branch
from
200588a to
e3e2cf8
Compare
scotthart
force-pushed
the
mtls_blob_option_rest
branch
from
e3e2cf8 to
f8785d3
Compare
2 participants
This change is