-
Notifications
You must be signed in to change notification settings - Fork 436
impl: add experimental client SSL certificate support #15062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| // Copyright 2025 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // https://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #ifndef GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_SSL_CERTIFICATE_H | ||
| #define GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_SSL_CERTIFICATE_H | ||
|
|
||
| #include "google/cloud/version.h" | ||
| #include <string> | ||
|
|
||
| namespace google { | ||
| namespace cloud { | ||
| GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN | ||
| namespace experimental { | ||
|
|
||
| /** | ||
| * Represents an SSL certificate used in TLS authentication. | ||
| */ | ||
| class SslCertificate { | ||
| public: | ||
| enum class SslCertificateType { kPEM, kDER, kP12 }; | ||
|
|
||
| /// Creates and empty certificate. | ||
| SslCertificate() = default; | ||
|
|
||
| /// Creates a PEM certificate from the values provided. | ||
| SslCertificate(std::string ssl_certificate, std::string ssl_private_key) | ||
| : ssl_certificate_(std::move(ssl_certificate)), | ||
| ssl_private_key_(std::move(ssl_private_key)) {} | ||
|
|
||
| /// Creates a user specified type of certificate from the values provided. | ||
| SslCertificate(std::string ssl_certificate, std::string ssl_private_key, | ||
| SslCertificateType ssl_certificate_type) | ||
| : ssl_certificate_(std::move(ssl_certificate)), | ||
| ssl_private_key_(std::move(ssl_private_key)), | ||
| ssl_certificate_type_(ssl_certificate_type) {} | ||
|
|
||
| std::string const& ssl_certificate() const { return ssl_certificate_; } | ||
|
|
||
| std::string const& ssl_private_key() const { return ssl_private_key_; } | ||
|
|
||
| SslCertificateType ssl_certificate_type() const { | ||
| return ssl_certificate_type_; | ||
| } | ||
|
|
||
| static std::string ToString(SslCertificateType type) { | ||
| switch (type) { | ||
| case SslCertificateType::kPEM: | ||
| return "PEM"; | ||
| case SslCertificateType::kDER: | ||
| return "DER"; | ||
| case SslCertificateType::kP12: | ||
| return "P12"; | ||
| } | ||
| return {}; | ||
| } | ||
|
|
||
| private: | ||
| std::string ssl_certificate_; | ||
| std::string ssl_private_key_; | ||
| SslCertificateType ssl_certificate_type_ = SslCertificateType::kPEM; | ||
| }; | ||
|
|
||
| } // namespace experimental | ||
| GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END | ||
| } // namespace cloud | ||
| } // namespace google | ||
|
|
||
| #endif // GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_SSL_CERTIFICATE_H | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea to encapsulate the properties in a class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did so hoping that we can reuse this for future features.