fix: fix 1000+ buckets pagination issue #15112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotthart
reviewed
Apr 28, 2025
Member
scotthart
left a comment
scotthart
left a comment
There was a problem hiding this comment.
Can we add some test(s) that reproduced the original issue and demonstrate its resolution?
Reviewable status: 0 of 1 files reviewed, all discussions resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15112 +/- ##
==========================================
- Coverage 92.92% 92.92% -0.01%
==========================================
Files 2391 2391
Lines 214995 215017 +22
==========================================
+ Hits 199793 199813 +20
- Misses 15202 15204 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddelgrosso1
reviewed
Apr 28, 2025
…ets request, which causes the 1000+ buckets infinite pagination loop
eliekozah
force-pushed
the
fix_broken_pagination_infinite_loop
branch
from
441eeb2 to
c02dd30
Compare
…ets request, which causes the 1000+ buckets infinite pagination loop
…ets request, which causes the 1000+ buckets infinite pagination loop
ddelgrosso1
reviewed
May 7, 2025
…ets request, which causes the 1000+ buckets infinite pagination loop
devbww
reviewed
May 7, 2025
…ets request, which causes the 1000+ buckets infinite pagination loop
devbww
reviewed
May 7, 2025
…ets request, which causes the 1000+ buckets infinite pagination loop
eliekozah
force-pushed
the
fix_broken_pagination_infinite_loop
branch
from
cb96490 to
e87525e
Compare
ddelgrosso1
approved these changes
May 7, 2025
scotthart
approved these changes
May 16, 2025
Member
scotthart
left a comment
scotthart
left a comment
There was a problem hiding this comment.
Reviewed 1 of 2 files at r2, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @ddelgrosso1, @devbww, and @eliekozah)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled the REST stub to pass along the
pageTokenquery so the existing pagination helper can automatically fetch the next page.#14915
This change is