impl(bigtable): populate Value proto with Type for parameters

[scotthart]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Bigtable client library's ability to represent query parameters by ensuring that the type information for each parameter is explicitly included in its protobuf serialization. This provides a more complete and accurate representation of the data being sent to the Bigtable service, which can be critical for correct query execution and type validation.

Highlights

• Parameter Type Population: The ToRequestProto method in BoundQuery now explicitly populates the type field within the google::bigtable::v2::Value protobuf for query parameters. Previously, only the value itself was set.
• Improved Type Fidelity: The change ensures that both the value and its corresponding type (e.g., bool_type, float64_type) are correctly transferred from the internal representation to the Bigtable V2 Value proto.
• Test Coverage: New assertions have been added to bound_query_test.cc to verify that the type field is correctly set for boolean and float parameters when converting to the request proto.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request implements the population of the Type field within the Value proto for query parameters. The changes in bound_query.cc correctly extract both type and value information and assemble the final protobuf message. The corresponding test updates in bound_query_test.cc properly verify this new behavior. I've included one suggestion to slightly refactor the implementation for improved efficiency and conciseness.

[gemini-code-assist]

This block can be simplified to avoid creating a temporary Value object and an extra move operation. You can directly operate on the map's value reference, which is slightly more efficient and readable.

    auto type_value = bigtable_internal::ValueInternals::ToProto(kv.second);
    auto& v = parameters[kv.first];
    v = std::move(type_value.second);
    *v.mutable_type() = std::move(type_value.first);

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.96%. Comparing base (ee87036) to head (6950c4a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #15752   +/-   ##
=======================================
  Coverage   92.95%   92.96%           
=======================================
  Files        2445     2445           
  Lines      226249   226254    +5     
=======================================
+ Hits       210310   210335   +25     
+ Misses      15939    15919   -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.