Skip to content

ci: install typos-cli in locked mode for checkers builds#15760

Merged
scotthart merged 4 commits intogoogleapis:mainfrom
scotthart:ci_checkers_typos_locked
Nov 13, 2025
Merged

ci: install typos-cli in locked mode for checkers builds#15760
scotthart merged 4 commits intogoogleapis:mainfrom
scotthart:ci_checkers_typos_locked

Conversation

@scotthart
Copy link
Member

No description provided.

@scotthart scotthart requested a review from a team November 13, 2025 18:03
@gemini-code-assist
Copy link

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the stability and reproducibility of CI builds by modifying the installation process for typos-cli within the checkers Docker image. By introducing the --locked flag to the cargo install command, the build system is now constrained to use the precise dependency versions recorded in the Cargo.lock file, preventing unexpected dependency updates and promoting consistent build outcomes for CI checks.

Highlights

  • CI Build Stability: The typos-cli tool is now installed with the --locked flag in the checkers.Dockerfile, ensuring that cargo uses the exact dependency versions specified in Cargo.lock for reproducible builds.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the --locked flag to the cargo install command for typos-cli, which is a great change for ensuring reproducible builds in CI. I've added one suggestion to further optimize the Docker layer by cleaning up the cargo cache after installation, which will help reduce the final image size.

ShellCheck

RUN cargo install typos-cli --version 1.24.1 --root /usr/local
RUN cargo install --locked typos-cli --version 1.24.1 --root /usr/local

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To reduce the Docker image size, it's a good practice to clean up the cargo cache after the installation is complete. You can chain rm -rf /root/.cargo to the RUN command to remove the cache in the same layer.

RUN cargo install --locked typos-cli --version 1.24.1 --root /usr/local && rm -rf /root/.cargo

diegomarquezp
diegomarquezp previously approved these changes Nov 13, 2025
@mpeddada1
Copy link
Collaborator

Looks like we're running into the following error even though we have dnf install cargo:

line 1: cargo: command not found

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.96%. Comparing base (829bce3) to head (7821be4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15760      +/-   ##
==========================================
+ Coverage   92.95%   92.96%   +0.01%     
==========================================
  Files        2448     2448              
  Lines      226256   226256              
==========================================
+ Hits       210305   210335      +30     
+ Misses      15951    15921      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart disabled auto-merge November 13, 2025 20:23
@scotthart scotthart enabled auto-merge (squash) November 13, 2025 20:23
@scotthart scotthart merged commit eac569c into googleapis:main Nov 13, 2025
68 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants