ci: install typos-cli in locked mode for checkers builds#15760
ci: install typos-cli in locked mode for checkers builds#15760scotthart merged 4 commits intogoogleapis:mainfrom
Conversation
Summary of ChangesHello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the stability and reproducibility of CI builds by modifying the installation process for Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds the --locked flag to the cargo install command for typos-cli, which is a great change for ensuring reproducible builds in CI. I've added one suggestion to further optimize the Docker layer by cleaning up the cargo cache after installation, which will help reduce the final image size.
| ShellCheck | ||
|
|
||
| RUN cargo install typos-cli --version 1.24.1 --root /usr/local | ||
| RUN cargo install --locked typos-cli --version 1.24.1 --root /usr/local |
There was a problem hiding this comment.
To reduce the Docker image size, it's a good practice to clean up the cargo cache after the installation is complete. You can chain rm -rf /root/.cargo to the RUN command to remove the cache in the same layer.
RUN cargo install --locked typos-cli --version 1.24.1 --root /usr/local && rm -rf /root/.cargo
|
Looks like we're running into the following error even though we have |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15760 +/- ##
==========================================
+ Coverage 92.95% 92.96% +0.01%
==========================================
Files 2448 2448
Lines 226256 226256
==========================================
+ Hits 210305 210335 +30
+ Misses 15951 15921 -30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.