impl(bigtable): conf test fail on incomplete data

[scotthart]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where Bigtable conformance tests were not fully exercising scenarios involving incomplete data. It updates the test runner script to include relevant tests and implements a crucial fix in the PartialResultSetSource to robustly handle cases where partial or malformed row data is encountered. This ensures the system correctly terminates processing and reports an informative error, improving the reliability and test coverage of Bigtable's data processing logic.

Highlights

• Conformance Test Updates: The Bigtable conformance test script has been updated to enable tests related to handling incomplete data (FailsOnNotEnoughData, FailsOnNotEnoughDataWithCompleteRows) and to include a new QueryPlan refresh recovery test (PlanRefresh_RecoversAfterPermanentError).
• Incomplete Data Handling Fix: A fix was implemented in PartialResultSetSource to correctly manage the state and provide a more descriptive error message when incomplete row data is encountered, ensuring the system transitions to a kFinished state upon detecting malformed input.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue where incomplete data from a Bigtable query stream could cause conformance tests to fail. The core change in partial_result_set_source.cc correctly handles this scenario by transitioning the result set source to a kFinished state and returning an error when an incomplete row is detected. This prevents further attempts to read from a broken stream. The error message has also been improved for better diagnostics. The accompanying changes in run_conformance_tests_proxy_bazel.sh re-enable conformance tests that were previously skipped, demonstrating that the fix is effective. The changes are correct and well-targeted. I have no further suggestions.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.94%. Comparing base (00a3e10) to head (8ea2b08).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...oud/bigtable/internal/partial_result_set_source.cc	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #15776   +/-   ##
=======================================
  Coverage   92.94%   92.94%           
=======================================
  Files        2449     2449           
  Lines      226520   226521    +1     
=======================================
+ Hits       210539   210544    +5     
+ Misses      15981    15977    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.