chore(deps): Update go version for go client smoke test#632
Merged
Conversation
product-auto-label
bot
added
the
api: eventarc
iennae
approved these changes
Jun 6, 2025
iennae
left a comment
iennae
left a comment
There was a problem hiding this comment.
LGTM;
In addition to moving to a more modern Go, I think the change in the syntax in specification of the Go version moves from locking to a minor version to a flexible within major version which feels ok to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go version in place was go 1.19. This change updates to use the latest patch release of go 1.23. This seems like it may address the build errors such as "google.golang.org/protobuf/internal/flags: cannot compile Go 1.22 code"
I would like to separate investigating the failing .NET and Java tests.
The unexpected changes check is failing because the protos have been updated, but the JSON Schema has not yet been updated. I am holding off on updating that until we see the tests passing based on the current state of the protos.
I would like to have a code review and required checks rules bypass merge to make this change despite the other failing tests.