test: added getSnapshotTimestamp() method
#4000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
|
@sakthivelmanii this PR requires #3995 to be merged first. |
skuruppu
force-pushed
the
rr_snapshot_timestamp
branch
2 times, most recently
from
ebf0582 to
77539dc
Compare
| * ran at, if the transaction ran at repeatable read isolation in internal test environments, and | ||
| * otherwise returns null. | ||
| */ | ||
| public @Nullable Timestamp getSnapshotTimestamp() { |
There was a problem hiding this comment.
nit: Can we add unit test for this method?
There was a problem hiding this comment.
That's a good idea. Done.
The snapshot timestamp is the timestamp at which all the reads in a transaction ran when using repeatable read isolation. The method is only intended to be used for internal testing purposes, so the snapshot timestamp will be `null` if attempted to be used externally.
skuruppu
force-pushed
the
rr_snapshot_timestamp
branch
from
77539dc to
5411e8f
Compare
|
Thanks for the review. PTAL @sakthivelmanii. |
sakthivelmanii
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The snapshot timestamp is the timestamp at which all the reads in a transaction ran when using repeatable read isolation. The method is only intended to be used for internal testing purposes, so the snapshot timestamp will be
nullif attempted to be used externally.