Skip to content

test: added getSnapshotTimestamp() method #4000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025
Merged

test: added getSnapshotTimestamp() method #4000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions google-cloud-spanner/src/main/java/com/google/cloud/spanner/CommitResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import com.google.cloud.Timestamp;
import com.google.common.base.Preconditions;
import java.util.Objects;
import javax.annotation.Nullable;

/** Represents a response from a commit operation. */
public class CommitResponse {
Expand All @@ -41,6 +42,18 @@ public Timestamp getCommitTimestamp() {
return Timestamp.fromProto(proto.getCommitTimestamp());
}

/**
* Returns a {@link Timestamp} representing the timestamp at which all reads in the transaction
* ran at, if the transaction ran at repeatable read isolation in internal test environments, and
* otherwise returns null.
*/
public @Nullable Timestamp getSnapshotTimestamp() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we add unit test for this method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea. Done.

if (proto.getSnapshotTimestamp() == com.google.protobuf.Timestamp.getDefaultInstance()) {
return null;
}
return Timestamp.fromProto(proto.getSnapshotTimestamp());
}

/**
* @return true if the {@link CommitResponse} includes {@link CommitStats}
*/
Expand Down
18 changes: 18 additions & 0 deletions google-cloud-spanner/src/test/java/com/google/cloud/spanner/CommitResponseTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,4 +101,22 @@ public void testHasCommitStats() {
CommitResponse responseWithCommitStats = new CommitResponse(protoWithCommitStats);
assertTrue(responseWithCommitStats.hasCommitStats());
}

@Test
public void testGetSnapshotTimestamp() {
com.google.spanner.v1.CommitResponse protoWithoutSnapshotTimestamp =
com.google.spanner.v1.CommitResponse.getDefaultInstance();
CommitResponse responseWithoutSnapshotTimestamp =
new CommitResponse(protoWithoutSnapshotTimestamp);
assertEquals(null, responseWithoutSnapshotTimestamp.getSnapshotTimestamp());

com.google.protobuf.Timestamp timestamp =
com.google.protobuf.Timestamp.newBuilder().setSeconds(123L).setNanos(456).build();
com.google.spanner.v1.CommitResponse protoWithSnapshotTimestamp =
com.google.spanner.v1.CommitResponse.newBuilder().setSnapshotTimestamp(timestamp).build();
CommitResponse responseWithSnapshotTimestamp = new CommitResponse(protoWithSnapshotTimestamp);
assertEquals(
Timestamp.ofTimeSecondsAndNanos(123L, 456),
responseWithSnapshotTimestamp.getSnapshotTimestamp());
}
}
Loading