chore: demo of changes from sdk-platform-java#3737#3029
Closed
diegomarquezp wants to merge 2 commits intomainfrom
Closed
chore: demo of changes from sdk-platform-java#3737#3029diegomarquezp wants to merge 2 commits intomainfrom
diegomarquezp wants to merge 2 commits intomainfrom
Conversation
See the PR in sdk-platform-java for more context. TL;DR: we are introducing an additional Kokoro job to run native tests against GraalVM for JDK 17.0.9
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
size: m
diegomarquezp
changed the title
| env_vars: { | ||
| key: "IT_SERVICE_ACCOUNT_EMAIL" | ||
| value: "it-service-account@gcloud-devel.iam.gserviceaccount.com" | ||
| } No newline at end of file |
Collaborator
There was a problem hiding this comment.
we should remove the existing graalvm configs if these are going to replace them
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing it out. Although this is just a draft, I was thinking of manually remove them once the generator image brings these templates (the generator doesn't remove templated files). I'll keep you posted with our decision.
Collaborator
There was a problem hiding this comment.
Two steps is okay in my mind, but it will put extra strain on the native image build pool have 5 configs instead of the 2 today or 3 tomorrow.
We'll also need to update the https://github.com/googleapis/java-storage/blob/main/.github/sync-repo-settings.yaml#L5-L21 so the correct jobs are PR gates
Contributor
Author
There was a problem hiding this comment.
extra strain
I meant to mention that the eventual template update PR would have a manual commit (by me) removing these configs. On the google3 side, there will only be a jump from 2 configs to 3.
sync-repo-settings
Thanks, I was missing that part of the migration.
Contributor
Author
There was a problem hiding this comment.
Ok, sync-repo-settings is a special case. The generation process can only create a new one, not update it. It will therefore be a manual commit in the eventual update PR.
.kokoro/build.sh
Outdated
Comment on lines
80
to
93
| graalvmA) | ||
| # Run Unit and Integration Tests with Native Image | ||
| mvn -B ${INTEGRATION_TEST_ARGS} -ntp -Pnative test | ||
| RETURN_CODE=$? | ||
| ;; | ||
| graalvmB) | ||
| # Run Unit and Integration Tests with Native Image | ||
| mvn -B ${INTEGRATION_TEST_ARGS} -ntp -Pnative test | ||
| RETURN_CODE=$? | ||
| ;; | ||
| graalvm17) | ||
| graalvmC) | ||
| # Run Unit and Integration Tests with Native Image | ||
| mvn -B ${INTEGRATION_TEST_ARGS} -ntp -Pnative test | ||
| RETURN_CODE=$? |
Collaborator
There was a problem hiding this comment.
Not sure why we need tree different job types that are all exactly the same.
Contributor
Author
There was a problem hiding this comment.
I discussed with @mpeddada1 and this redundancy was probably kept under the assumption they may eventually differ, but it hasn't happened so far. Thanks again for pointing this inconsistency out. I'll soon use a singe graalvm) case.
Contributor
Author
There was a problem hiding this comment.
We decided to just use graalvm)
diegomarquezp
added a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Apr 14, 2025
Context: [we will introduce a new GraalVM job](https://docs.google.com/document/d/1bOeGtVFLsq5ts71If5pFXCvHIeNpbtBRvF6XQfavLZs/edit?tab=t.dcjxhf429j6t#bookmark=id.3s7d4dj247hr) and will leverage the hermetic build templates to propagate this change to some of the repositories. Each PR will be followed with ad-hoc changes such as sync-repo-settings (the cannot be templated). Demo PRs * googleapis/java-bigtable#2558 * googleapis/java-bigquerystorage#2937 * googleapis/java-storage#3029 * googleapis/java-datastore#1816 * There are manual changes in `build.sh`. We will add this file to the [ignored files in owlbot.py](https://github.com/googleapis/java-datastore/blob/8ceb62b5182e30b4f771d6c1b586a22fb084c9ac/owlbot.py#L48-L57) and will raise an issue to move this logic elsewhere (if feasible). * googleapis/java-firestore#2074 * googleapis/java-logging#1789 * googleapis/java-pubsub#2389 * googleapis/java-pubsublite#1839 * googleapis/java-spanner#3821
lqiu96
pushed a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Apr 17, 2025
Context: [we will introduce a new GraalVM job](https://docs.google.com/document/d/1bOeGtVFLsq5ts71If5pFXCvHIeNpbtBRvF6XQfavLZs/edit?tab=t.dcjxhf429j6t#bookmark=id.3s7d4dj247hr) and will leverage the hermetic build templates to propagate this change to some of the repositories. Each PR will be followed with ad-hoc changes such as sync-repo-settings (the cannot be templated). Demo PRs * googleapis/java-bigtable#2558 * googleapis/java-bigquerystorage#2937 * googleapis/java-storage#3029 * googleapis/java-datastore#1816 * There are manual changes in `build.sh`. We will add this file to the [ignored files in owlbot.py](https://github.com/googleapis/java-datastore/blob/8ceb62b5182e30b4f771d6c1b586a22fb084c9ac/owlbot.py#L48-L57) and will raise an issue to move this logic elsewhere (if feasible). * googleapis/java-firestore#2074 * googleapis/java-logging#1789 * googleapis/java-pubsub#2389 * googleapis/java-pubsublite#1839 * googleapis/java-spanner#3821
lqiu96
pushed a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Jun 10, 2025
Context: [we will introduce a new GraalVM job](https://docs.google.com/document/d/1bOeGtVFLsq5ts71If5pFXCvHIeNpbtBRvF6XQfavLZs/edit?tab=t.dcjxhf429j6t#bookmark=id.3s7d4dj247hr) and will leverage the hermetic build templates to propagate this change to some of the repositories. Each PR will be followed with ad-hoc changes such as sync-repo-settings (the cannot be templated). Demo PRs * googleapis/java-bigtable#2558 * googleapis/java-bigquerystorage#2937 * googleapis/java-storage#3029 * googleapis/java-datastore#1816 * There are manual changes in `build.sh`. We will add this file to the [ignored files in owlbot.py](https://github.com/googleapis/java-datastore/blob/8ceb62b5182e30b4f771d6c1b586a22fb084c9ac/owlbot.py#L48-L57) and will raise an issue to move this logic elsewhere (if feasible). * googleapis/java-firestore#2074 * googleapis/java-logging#1789 * googleapis/java-pubsub#2389 * googleapis/java-pubsublite#1839 * googleapis/java-spanner#3821
lqiu96
pushed a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Aug 21, 2025
Context: [we will introduce a new GraalVM job](https://docs.google.com/document/d/1bOeGtVFLsq5ts71If5pFXCvHIeNpbtBRvF6XQfavLZs/edit?tab=t.dcjxhf429j6t#bookmark=id.3s7d4dj247hr) and will leverage the hermetic build templates to propagate this change to some of the repositories. Each PR will be followed with ad-hoc changes such as sync-repo-settings (the cannot be templated). Demo PRs * googleapis/java-bigtable#2558 * googleapis/java-bigquerystorage#2937 * googleapis/java-storage#3029 * googleapis/java-datastore#1816 * There are manual changes in `build.sh`. We will add this file to the [ignored files in owlbot.py](https://github.com/googleapis/java-datastore/blob/8ceb62b5182e30b4f771d6c1b586a22fb084c9ac/owlbot.py#L48-L57) and will raise an issue to move this logic elsewhere (if feasible). * googleapis/java-firestore#2074 * googleapis/java-logging#1789 * googleapis/java-pubsub#2389 * googleapis/java-pubsublite#1839 * googleapis/java-spanner#3821
lqiu96
pushed a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Aug 27, 2025
Context: [we will introduce a new GraalVM job](https://docs.google.com/document/d/1bOeGtVFLsq5ts71If5pFXCvHIeNpbtBRvF6XQfavLZs/edit?tab=t.dcjxhf429j6t#bookmark=id.3s7d4dj247hr) and will leverage the hermetic build templates to propagate this change to some of the repositories. Each PR will be followed with ad-hoc changes such as sync-repo-settings (the cannot be templated). Demo PRs * googleapis/java-bigtable#2558 * googleapis/java-bigquerystorage#2937 * googleapis/java-storage#3029 * googleapis/java-datastore#1816 * There are manual changes in `build.sh`. We will add this file to the [ignored files in owlbot.py](https://github.com/googleapis/java-datastore/blob/8ceb62b5182e30b4f771d6c1b586a22fb084c9ac/owlbot.py#L48-L57) and will raise an issue to move this logic elsewhere (if feasible). * googleapis/java-firestore#2074 * googleapis/java-logging#1789 * googleapis/java-pubsub#2389 * googleapis/java-pubsublite#1839 * googleapis/java-spanner#3821
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See sdk-platform-java#3737 for more context.
TL;DR: we are introducing an additional Kokoro job to run native tests against GraalVM for JDK 17.0.9