Skip to content

chore: introduce .kokoro templates for GraalVM jobs#3737

Merged
diegomarquezp merged 9 commits intomainfrom
restore-kokoro-graalvm-jobs
Apr 14, 2025
Merged

chore: introduce .kokoro templates for GraalVM jobs#3737
diegomarquezp merged 9 commits intomainfrom
restore-kokoro-graalvm-jobs

Conversation

@diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Apr 10, 2025

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Apr 10, 2025
diegomarquezp added a commit to googleapis/java-storage that referenced this pull request Apr 10, 2025
See the PR in sdk-platform-java for more context.
TL;DR: we are introducing an additional Kokoro job to run native tests against GraalVM for JDK 17.0.9
diegomarquezp added a commit to googleapis/java-bigquerystorage that referenced this pull request Apr 11, 2025
See [sdk-platform-java#3737](googleapis/sdk-platform-java#3737) for more context.
TL;DR: we are introducing an additional Kokoro job to run native tests against GraalVM for JDK 17.0.9
diegomarquezp added a commit to googleapis/java-bigtable that referenced this pull request Apr 11, 2025
See [sdk-platform-java#3737](googleapis/sdk-platform-java#3737) for more context.
TL;DR: we are introducing an additional Kokoro job to run native tests against GraalVM for JDK 17.0.9
diegomarquezp added a commit to googleapis/java-datastore that referenced this pull request Apr 14, 2025
See [sdk-platform-java#3737](googleapis/sdk-platform-java#3737) for more context.
TL;DR: we are introducing an additional Kokoro job to run native tests against GraalVM for JDK 17.0.9
diegomarquezp added a commit to googleapis/java-firestore that referenced this pull request Apr 14, 2025
See [sdk-platform-java#3737](googleapis/sdk-platform-java#3737) for more context.
TL;DR: we are introducing an additional Kokoro job to run native tests against GraalVM for JDK 17.0.9
diegomarquezp added a commit to googleapis/java-logging that referenced this pull request Apr 14, 2025
See [sdk-platform-java#3737](googleapis/sdk-platform-java#3737) for more context.
TL;DR: we are introducing an additional Kokoro job to run native tests against GraalVM for JDK 17.0.9
diegomarquezp added a commit to googleapis/java-pubsub that referenced this pull request Apr 14, 2025
See [sdk-platform-java#3737](googleapis/sdk-platform-java#3737) for more context.
TL;DR: we are introducing an additional Kokoro job to run native tests against GraalVM for JDK 17.0.9
diegomarquezp added a commit to googleapis/java-pubsublite that referenced this pull request Apr 14, 2025
See [sdk-platform-java#3737](googleapis/sdk-platform-java#3737) for more context.
TL;DR: we are introducing an additional Kokoro job to run native tests against GraalVM for JDK 17.0.9
diegomarquezp added a commit to googleapis/java-spanner that referenced this pull request Apr 14, 2025
See [sdk-platform-java#3737](googleapis/sdk-platform-java#3737) for more context.
TL;DR: we are introducing an additional Kokoro job to run native tests against GraalVM for JDK 17.0.9
@diegomarquezp diegomarquezp marked this pull request as ready for review April 14, 2025 17:01
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what exactly does graalvm-a/b/c mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full context is in a new support policy for GraalVM images. TLDR is that we want to keep a few placeholder jobs for frequently changing GraalVM images (e.g. we will now suport GraalVM for JDK 17 (C), 21 (A) and 23 (B)). In this way, we can avoid renaming the jobs based on the JDK versions these images run on.

Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I give my LGTM but shall we stop naming the job as "-a", "-b", and "-c"? It's unclear what's being tested.

- "cla/google"
- "OwlBot Post Processor"
- "Kokoro - Test: Java GraalVM Native Image"
- "Kokoro - Test: Java 17 GraalVM Native Image"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unclear what is tested.

@diegomarquezp diegomarquezp requested a review from blakeli0 April 14, 2025 19:59
@diegomarquezp diegomarquezp added the automerge Merge the pull request once unit tests and other checks pass. label Apr 14, 2025
@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@diegomarquezp diegomarquezp merged commit 07fb39d into main Apr 14, 2025
52 of 53 checks passed
@diegomarquezp diegomarquezp deleted the restore-kokoro-graalvm-jobs branch April 14, 2025 23:48
# Configure the docker image for kokoro-trampoline.
env_vars: {
key: "TRAMPOLINE_IMAGE"
value: "gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform_b:3.45.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change this according to the file name

lqiu96 pushed a commit that referenced this pull request Apr 17, 2025
Context: [we will introduce a new GraalVM
job](https://docs.google.com/document/d/1bOeGtVFLsq5ts71If5pFXCvHIeNpbtBRvF6XQfavLZs/edit?tab=t.dcjxhf429j6t#bookmark=id.3s7d4dj247hr)
and will leverage the hermetic build templates to propagate this change
to some of the repositories. Each PR will be followed with ad-hoc
changes such as sync-repo-settings (the cannot be templated).

Demo PRs
 * googleapis/java-bigtable#2558
 * googleapis/java-bigquerystorage#2937
 * googleapis/java-storage#3029
 * googleapis/java-datastore#1816
* There are manual changes in `build.sh`. We will add this file to the
[ignored files in
owlbot.py](https://github.com/googleapis/java-datastore/blob/8ceb62b5182e30b4f771d6c1b586a22fb084c9ac/owlbot.py#L48-L57)
and will raise an issue to move this logic elsewhere (if feasible).
 * googleapis/java-firestore#2074
 * googleapis/java-logging#1789
 * googleapis/java-pubsub#2389
 * googleapis/java-pubsublite#1839
 * googleapis/java-spanner#3821
lqiu96 pushed a commit that referenced this pull request Jun 10, 2025
Context: [we will introduce a new GraalVM
job](https://docs.google.com/document/d/1bOeGtVFLsq5ts71If5pFXCvHIeNpbtBRvF6XQfavLZs/edit?tab=t.dcjxhf429j6t#bookmark=id.3s7d4dj247hr)
and will leverage the hermetic build templates to propagate this change
to some of the repositories. Each PR will be followed with ad-hoc
changes such as sync-repo-settings (the cannot be templated).

Demo PRs
 * googleapis/java-bigtable#2558
 * googleapis/java-bigquerystorage#2937
 * googleapis/java-storage#3029
 * googleapis/java-datastore#1816
* There are manual changes in `build.sh`. We will add this file to the
[ignored files in
owlbot.py](https://github.com/googleapis/java-datastore/blob/8ceb62b5182e30b4f771d6c1b586a22fb084c9ac/owlbot.py#L48-L57)
and will raise an issue to move this logic elsewhere (if feasible).
 * googleapis/java-firestore#2074
 * googleapis/java-logging#1789
 * googleapis/java-pubsub#2389
 * googleapis/java-pubsublite#1839
 * googleapis/java-spanner#3821
lqiu96 pushed a commit that referenced this pull request Aug 21, 2025
Context: [we will introduce a new GraalVM
job](https://docs.google.com/document/d/1bOeGtVFLsq5ts71If5pFXCvHIeNpbtBRvF6XQfavLZs/edit?tab=t.dcjxhf429j6t#bookmark=id.3s7d4dj247hr)
and will leverage the hermetic build templates to propagate this change
to some of the repositories. Each PR will be followed with ad-hoc
changes such as sync-repo-settings (the cannot be templated).

Demo PRs
 * googleapis/java-bigtable#2558
 * googleapis/java-bigquerystorage#2937
 * googleapis/java-storage#3029
 * googleapis/java-datastore#1816
* There are manual changes in `build.sh`. We will add this file to the
[ignored files in
owlbot.py](https://github.com/googleapis/java-datastore/blob/8ceb62b5182e30b4f771d6c1b586a22fb084c9ac/owlbot.py#L48-L57)
and will raise an issue to move this logic elsewhere (if feasible).
 * googleapis/java-firestore#2074
 * googleapis/java-logging#1789
 * googleapis/java-pubsub#2389
 * googleapis/java-pubsublite#1839
 * googleapis/java-spanner#3821
lqiu96 pushed a commit that referenced this pull request Aug 27, 2025
Context: [we will introduce a new GraalVM
job](https://docs.google.com/document/d/1bOeGtVFLsq5ts71If5pFXCvHIeNpbtBRvF6XQfavLZs/edit?tab=t.dcjxhf429j6t#bookmark=id.3s7d4dj247hr)
and will leverage the hermetic build templates to propagate this change
to some of the repositories. Each PR will be followed with ad-hoc
changes such as sync-repo-settings (the cannot be templated).

Demo PRs
 * googleapis/java-bigtable#2558
 * googleapis/java-bigquerystorage#2937
 * googleapis/java-storage#3029
 * googleapis/java-datastore#1816
* There are manual changes in `build.sh`. We will add this file to the
[ignored files in
owlbot.py](https://github.com/googleapis/java-datastore/blob/8ceb62b5182e30b4f771d6c1b586a22fb084c9ac/owlbot.py#L48-L57)
and will raise an issue to move this logic elsewhere (if feasible).
 * googleapis/java-firestore#2074
 * googleapis/java-logging#1789
 * googleapis/java-pubsub#2389
 * googleapis/java-pubsublite#1839
 * googleapis/java-spanner#3821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the pull request once unit tests and other checks pass. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants