Skip to content

feat(sidekick/rust): Improve generated samples format.#4067

Open
amanda-tarafa wants to merge 1 commit intogoogleapis:mainfrom
amanda-tarafa:format-samples
Open

feat(sidekick/rust): Improve generated samples format.#4067
amanda-tarafa wants to merge 1 commit intogoogleapis:mainfrom
amanda-tarafa:format-samples

Conversation

@amanda-tarafa
Copy link
Contributor

This approach balances vertical vs. horizontal sample size. And we we don't need the newline-in-comment trick to keep the templates readable.

@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.93%. Comparing base (d54fc6a) to head (c8a32e3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4067   +/-   ##
=======================================
  Coverage   81.93%   81.93%           
=======================================
  Files          78       78           
  Lines        6516     6516           
=======================================
  Hits         5339     5339           
  Misses        832      832           
  Partials      345      345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the formatting of generated Rust code samples, making them more readable by using a multi-line builder pattern. The changes are generally good, but I've found a critical issue where a leftover template tag will cause a syntax error in the generated code. I've also included a suggestion to improve consistency in the new formatting style.

This approach balances vertical vs. horizontal sample size.
And we we don't need the newline-in-comment trick to keep the templates readable.
@amanda-tarafa amanda-tarafa marked this pull request as ready for review February 14, 2026 07:16
@amanda-tarafa amanda-tarafa requested a review from a team as a code owner February 14, 2026 07:16
@amanda-tarafa
Copy link
Contributor Author

Ready for review, generation results can be seen on the second commit of googleapis/google-cloud-rust#4678.

@coryan I'm happy to further tweak this or try with cargo fmt, but I think this looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant