Skip to content

feat(sidekick/rust): Improve generated samples format. #4067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amanda-tarafa wants to merge 1 commit into
base: main
Choose a base branch
from
+51 −66
Open

feat(sidekick/rust): Improve generated samples format. #4067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 30 additions & 31 deletions internal/sidekick/rust/templates/common/client_method_samples/builder_fields.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,34 +12,33 @@ distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
}}{{!
Terminate each line in a comment so
(a) we can read this code as each case is in a separate line,and
(b) the newline is suppressed in the output to get tighter code.
Use no newline at the end of file so the partials are all merged into a single line.
}}{{#AIPStandardGetInfo}}{{!
}}.set_{{ResourceNameRequestField.Codec.SetterName}}(resource_name){{!
}}{{/AIPStandardGetInfo}}{{!
}}{{#AIPStandardDeleteInfo}}{{!
}}.set_{{ResourceNameRequestField.Codec.SetterName}}(resource_name){{!
}}{{/AIPStandardDeleteInfo}}{{!
}}{{#AIPStandardUndeleteInfo}}{{!
}}.set_{{ResourceNameRequestField.Codec.SetterName}}(resource_name){{!
}}{{/AIPStandardUndeleteInfo}}{{!
}}{{#AIPStandardCreateInfo}}{{!
}}.set_{{ParentRequestField.Codec.SetterName}}(parent){{!
}}{{#ResourceIDRequestField}}{{!
}}.set_{{Codec.SetterName}}(id){{!
}}{{/ResourceIDRequestField}}{{!
}}.set_{{ResourceRequestField.Codec.SetterName}}({{ResourceRequestField.MessageType.Codec.Name}}::new()/* set fields */){{!
}}{{/AIPStandardCreateInfo}}{{!
}}{{#AIPStandardUpdateInfo}}{{!
}}.set_{{ResourceRequestField.Codec.SetterName}}({{ResourceRequestField.MessageType.Codec.Name}}::new().set_name(name)/* set fields */){{!
}}{{#UpdateMaskRequestField}}{{!
}}.set_{{Codec.SetterName}}(FieldMask::default().set_paths(["updated", "fields"])){{!
}}{{/UpdateMaskRequestField}}{{!
}}{{/AIPStandardUpdateInfo}}{{!
}}{{#AIPStandardListInfo}}{{!
}}.set_{{ParentRequestField.Codec.SetterName}}(parent){{!
}}{{/AIPStandardListInfo}}{{!
}}{{^IsAIPStandard}}/* set fields */{{/IsAIPStandard}}
}}
{{#AIPStandardGetInfo}}
/// .set_{{ResourceNameRequestField.Codec.SetterName}}(resource_name)
{{/AIPStandardGetInfo}}
{{#AIPStandardDeleteInfo}}
/// .set_{{ResourceNameRequestField.Codec.SetterName}}(resource_name)
{{/AIPStandardDeleteInfo}}
{{#AIPStandardUndeleteInfo}}
/// .set_{{ResourceNameRequestField.Codec.SetterName}}(resource_name)
{{/AIPStandardUndeleteInfo}}
{{#AIPStandardCreateInfo}}
/// .set_{{ParentRequestField.Codec.SetterName}}(parent){{#ResourceIDRequestField}}.set_{{Codec.SetterName}}("{{Codec.SetterName}}_value"){{/ResourceIDRequestField}}
/// .set_{{ResourceRequestField.Codec.SetterName}}(
/// {{ResourceRequestField.MessageType.Codec.Name}}::new()/* set fields */
/// )
{{/AIPStandardCreateInfo}}
{{#AIPStandardUpdateInfo}}
/// .set_{{ResourceRequestField.Codec.SetterName}}(
/// {{ResourceRequestField.MessageType.Codec.Name}}::new().set_name(name)/* set fields */
/// )
{{#UpdateMaskRequestField}}
/// .set_{{Codec.SetterName}}(FieldMask::default().set_paths(["updated.field.path1", "updated.field.path2"]))
{{/UpdateMaskRequestField}}
{{/AIPStandardUpdateInfo}}
{{#AIPStandardListInfo}}
/// .set_{{ParentRequestField.Codec.SetterName}}(parent)
{{/AIPStandardListInfo}}
{{^IsAIPStandard}}
/// /* set fields */
{{/IsAIPStandard}}
35 changes: 15 additions & 20 deletions internal/sidekick/rust/templates/common/client_method_samples/method_call.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,41 +13,36 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
}}
{{!
Terminate some lines in a comment so
(a) we can read this code as each case is in a separate line,and
(b) the newline is suppressed in the output to get tighter code.
}}
{{#IsSimple}}
{{#ReturnsEmpty}}
/// client.{{Codec.Name}}(){{!
}}{{> /templates/common/client_method_samples/builder_fields}}{{!
}}.send().await?;
/// client.{{Codec.Name}}()
{{> /templates/common/client_method_samples/builder_fields}}
/// .send().await?;
{{/ReturnsEmpty}}
{{^ReturnsEmpty}}
/// let response = client.{{Codec.Name}}(){{!
}}{{> /templates/common/client_method_samples/builder_fields}}{{!
}}.send().await?;
/// let response = client.{{Codec.Name}}()
{{> /templates/common/client_method_samples/builder_fields}}
/// .send().await?;
/// println!("response {:?}", response);
{{/ReturnsEmpty}}
{{/IsSimple}}
{{#IsLRO}}
{{#LongRunningReturnsEmpty}}
/// client.{{Codec.Name}}(){{!
}}{{> /templates/common/client_method_samples/builder_fields}}{{!
}}.poller().until_done().await?;
/// client.{{Codec.Name}}()
{{> /templates/common/client_method_samples/builder_fields}}
/// .poller().until_done().await?;
{{/LongRunningReturnsEmpty}}
{{^LongRunningReturnsEmpty}}
/// let response = client.{{Codec.Name}}(){{!
}}{{> /templates/common/client_method_samples/builder_fields}}{{!
}}.poller().until_done().await?;
/// let response = client.{{Codec.Name}}()
{{> /templates/common/client_method_samples/builder_fields}}
/// .poller().until_done().await?;
/// println!("response {:?}", response);
{{/LongRunningReturnsEmpty}}
{{/IsLRO}}
{{#IsList}}
/// let mut list = client.{{Codec.Name}}(){{!
}}{{> /templates/common/client_method_samples/builder_fields}}{{!
}}.by_item();
/// let mut list = client.{{Codec.Name}}()
{{> /templates/common/client_method_samples/builder_fields}}
/// .by_item();
/// while let Some(item) = list.next().await.transpose()? {
/// println!("{:?}", item);
/// }
Expand Down
21 changes: 6 additions & 15 deletions internal/sidekick/rust/templates/common/client_method_samples/parameters.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,31 +14,22 @@ See the License for the specific language governing permissions and
limitations under the License.
}}
{{#AIPStandardGetInfo}}
/// client: &{{Service.Codec.Name}},
/// resource_name: &str
/// client: &{{Service.Codec.Name}}, resource_name: &str
{{/AIPStandardGetInfo}}
{{#AIPStandardDeleteInfo}}
/// client: &{{Service.Codec.Name}},
/// resource_name: &str
/// client: &{{Service.Codec.Name}}, resource_name: &str
{{/AIPStandardDeleteInfo}}
{{#AIPStandardUndeleteInfo}}
/// client: &{{Service.Codec.Name}},
/// resource_name: &str
/// client: &{{Service.Codec.Name}}, resource_name: &str
{{/AIPStandardUndeleteInfo}}
{{#AIPStandardCreateInfo}}
/// client: &{{Service.Codec.Name}},
/// parent: &str,
{{#ResourceIDRequestField}}
/// id: &str
{{/ResourceIDRequestField}}
/// client: &{{Service.Codec.Name}}, parent: &str
{{/AIPStandardCreateInfo}}
{{#AIPStandardUpdateInfo}}
/// client: &{{Service.Codec.Name}},
/// name: &str
/// client: &{{Service.Codec.Name}}, name: &str
{{/AIPStandardUpdateInfo}}
{{#AIPStandardListInfo}}
/// client: &{{Service.Codec.Name}},
/// parent: &str
/// client: &{{Service.Codec.Name}}, parent: &str
{{/AIPStandardListInfo}}
{{^IsAIPStandard}}
/// client: &{{Service.Codec.Name}}
Expand Down
Loading