Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4630 +/- ##
==========================================
+ Coverage 79.27% 79.75% +0.47%
==========================================
Files 110 110
Lines 9275 9275
==========================================
+ Hits 7353 7397 +44
+ Misses 1410 1346 -64
- Partials 512 532 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| go install google.golang.org/protobuf/cmd/protoc-gen-go@v${GO_PROTOC_PLUGIN_VERSION} | ||
| go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@v${GO_PROTOC_GRPC_PLUGIN_VERSION} | ||
| go install github.com/googleapis/gapic-generator-go/cmd/protoc-gen-go_gapic@v${GO_GAPIC_VERSION} | ||
| go install golang.org/x/tools/cmd/goimports@latest |
There was a problem hiding this comment.
I tried to install dependencies using go mod tidy since these dependencies are listed in go.mod but it didn't work.
There was a problem hiding this comment.
Use go tool install https://tip.golang.org/doc/go1.24#tools
Also I'm not sure I understand why you need this. The tests run in .github/workflows/librarian.yaml
There was a problem hiding this comment.
Also I'm not sure I understand why you need this. The tests run in .github/workflows/librarian.yaml
I tested that not all unit tests are run in that workflow because some unit tests require toolings installed, e.g., gapic-generator-go.
The golang tests in this workflow runs for 12s while in librarian.yaml it only needs 2s.
| uses: codecov/codecov-action@v5 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| create-issue-on-failure: |
There was a problem hiding this comment.
It might make sense to create a .github/workflows/postsubmit.yaml file, so that we can share the same template across languages
|
@JoeWang1127 - I'm not sure we need this PR if we are going to do #4631 |
I think we still need this change because not all golang unit tests are running in CI. |
2 participants
Add golang workflow, install Go dependencies to run all unit tests in golang package.
Fixes #4628