Skip to content

Conversation

@zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Nov 19, 2025

These are test only dependencies, dependabot alerts should not matter as code is not shipped and test is in controlled env.
However, it is good practice to update versions when possible.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 19, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @zhumin8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating and standardizing Logback test dependencies within the java-showcase/gapic-showcase module. The changes address potential Dependabot alerts by introducing a dedicated property for SLF4J 2.x compatible Logback versions and ensuring consistent versioning for SLF4J 1.x compatible Logback components, improving overall dependency management and reducing future maintenance overhead for test environments.

Highlights

  • New Logback Version Property: Introduced a new property, slf4j2-logback.version, set to 1.5.21, to manage Logback versions compatible with SLF4J 2.x.
  • Logback Dependency Updates: Updated logback-classic and logback-core test dependencies to utilize the newly defined slf4j2-logback.version property.
  • Logback Version Harmonization: Corrected and harmonized logback-classic and logback-core test dependencies to consistently use the slf4j1-logback.version property, specifically fixing logback-core from 1.3.15 to 1.2.13.
  • Version Comment Clarification: Added a comment to the slf4j1-logback.version property, clarifying that it represents the last version supporting SLF4J 1.x.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates and fixes the logback dependency versions used for testing. The changes are well-structured, introducing a new Maven property for logback versions compatible with SLF4J 2.x and using it to update the dependencies. This also fixes an incorrect logback-core version in one of the profiles, ensuring compatibility with SLF4J 1.x. These changes improve the project's maintainability and correctness. I have one minor suggestion to improve code cleanliness.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant