chore: update and fix logback versions used in test #3990
Conversation
Summary of ChangesHello @zhumin8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating and standardizing Logback test dependencies within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates and fixes the logback dependency versions used for testing. The changes are well-structured, introducing a new Maven property for logback versions compatible with SLF4J 2.x and using it to update the dependencies. This also fixes an incorrect logback-core version in one of the profiles, ensuring compatibility with SLF4J 1.x. These changes improve the project's maintainability and correctness. I have one minor suggestion to improve code cleanliness.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
|
1 participant
These are test only dependencies, dependabot alerts should not matter as code is not shipped and test is in controlled env.
However, it is good practice to update versions when possible.