Skip to content

chore: cleanup release-please config #4002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diegomarquezp wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: cleanup release-please config #4002

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6dd41b7
chore: cleanup release-please config
diegomarquezp Dec 5, 2025
089b27e
chore: reorder branch keys for consistency
diegomarquezp Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 22 additions & 52 deletions .github/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,56 +4,26 @@ handleGHRelease: true
primaryBranch: main
manifest: true
extraFiles:
- WORKSPACE
- .cloudbuild/graalvm/cloudbuild.yaml
- .cloudbuild/graalvm/cloudbuild-test-a.yaml
- .cloudbuild/graalvm/cloudbuild-test-b.yaml
- .cloudbuild/graalvm/cloudbuild-test-c.yaml
- .cloudbuild/library_generation/cloudbuild-library-generation-release.yaml
- >-
hermetic_build/library_generation/owlbot/templates/java_library/.kokoro/presubmit/graalvm-native-a.cfg
- >-
hermetic_build/library_generation/owlbot/templates/java_library/.kokoro/presubmit/graalvm-native-b.cfg
- >-
hermetic_build/library_generation/owlbot/templates/java_library/.kokoro/presubmit/graalvm-native-c.cfg
- generation_config.yaml
- WORKSPACE
- .cloudbuild/graalvm/cloudbuild.yaml
- .cloudbuild/graalvm/cloudbuild-test-a.yaml
- .cloudbuild/graalvm/cloudbuild-test-b.yaml
- .cloudbuild/graalvm/cloudbuild-test-c.yaml
- .cloudbuild/library_generation/cloudbuild-library-generation-release.yaml
- >-
hermetic_build/library_generation/owlbot/templates/java_library/.kokoro/presubmit/graalvm-native-a.cfg
- >-
hermetic_build/library_generation/owlbot/templates/java_library/.kokoro/presubmit/graalvm-native-b.cfg
- >-
hermetic_build/library_generation/owlbot/templates/java_library/.kokoro/presubmit/graalvm-native-c.cfg
- generation_config.yaml
branches:
- branch: protobuf-4.x-rc
bumpMinorPreMajor: true
handleGHRelease: true
manifest: true
releaseType: java-yoshi
- branch: 2.23.x
releaseType: java-backport
manifest: true
handleGHRelease: true
- branch: 2.40.x
releaseType: java-backport
manifest: true
handleGHRelease: true
- releaseType: java-backport
bumpMinorPreMajor: true
handleGHRelease: true
manifest: true
branch: 2.54.x
- releaseType: java-backport
bumpMinorPreMajor: true
handleGHRelease: true
primaryBranch: main
manifest: true
extraFiles:
- WORKSPACE
- .cloudbuild/graalvm/cloudbuild.yaml
- .cloudbuild/graalvm/cloudbuild-test-a.yaml
- .cloudbuild/graalvm/cloudbuild-test-b.yaml
- .cloudbuild/graalvm/cloudbuild-test-c.yaml
- >-
.cloudbuild/library_generation/cloudbuild-library-generation-release.yaml
- >-
hermetic_build/library_generation/owlbot/templates/java_library/.kokoro/presubmit/graalvm-native-a.cfg
- >-
hermetic_build/library_generation/owlbot/templates/java_library/.kokoro/presubmit/graalvm-native-b.cfg
- >-
hermetic_build/library_generation/owlbot/templates/java_library/.kokoro/presubmit/graalvm-native-c.cfg
- generation_config.yaml
branch: 2.59.x
- branch: protobuf-4.x-rc
- branch: 2.23.x
releaseType: java-backport
- branch: 2.40.x
releaseType: java-backport
- releaseType: java-backport
branch: 2.54.x
- releaseType: java-backport
branch: 2.59.x
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other branch configurations in this file (like 2.23.x), it's better to list the branch key first. This improves readability and makes the file easier to maintain.

    - branch: 2.54.x
      releaseType: java-backport
    - branch: 2.59.x
      releaseType: java-backport

Loading