chore: added screenshot testing #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Code Coverage
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dkhawk
approved these changes
Dec 6, 2024
Collaborator
Author
|
The difference in the expected and resulting images could be due to an issue with the antialiasing, bug has already been filled here: |
dkhawk
approved these changes
Dec 10, 2024
Contributor
|
🎉 This PR is included in version 6.4.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR provides screenshot testing for the ScaleBar composable, and integration with GitHub flows.
We have no UI coverage for the map due to the impossibility of testing the GoogleMap composable. However, smaller and independent composables, like the ScaleBar, can be tested without having to render the map. This should also run on the GitHub test action, to make sure that further development is not introducing regressions.